New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-libs/assimp: add 5.2.5-r2, add 5.3.1 #34346
Conversation
Pull Request assignmentSubmitter: @negril media-libs/assimp: @waebbl, @gentoo/proxy-maint Linked bugsBugs linked: 919896, 910362, 908403 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
54ae174
to
2f4772a
Compare
Pull request CI reportReport generated at: 2023-12-18 15:57 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2023-12-18 16:13 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
2f4772a
to
e1f4ef9
Compare
Pull request CI reportReport generated at: 2023-12-19 00:28 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
e1f4ef9
to
be27230
Compare
Pull request CI reportReport generated at: 2023-12-24 16:18 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
be27230
to
3f6cd42
Compare
Pull request CI reportReport generated at: 2023-12-28 15:29 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
3f6cd42
to
16d6e70
Compare
Pull request CI reportReport generated at: 2023-12-29 10:19 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Rework tests to make use of gtest via ctest. Some tests generate random input data which might fail on fma-enabled CPUs due to smaller rounding errors on fused operations, so we repeat those tests until they succeed. Closes: https://bugs.gentoo.org/908403 Closes: https://bugs.gentoo.org/910362 Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
16d6e70
to
05b6f38
Compare
Pull request CI reportReport generated at: 2023-12-29 13:59 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
@@ -0,0 +1,84 @@ | |||
diff --git a/include/assimp/matrix3x3.inl b/include/assimp/matrix3x3.inl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you come back to this, please add some explanation to the top. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit-wise floating point number comparison is down right criminal... It's also a wild mix in there so I just use the operators with tolerances.
"^utIssues.OpacityBugWhenExporting_727$" | ||
) | ||
myctestargs+=( | ||
--repeat until-pass:100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deserves a comment above it, please explain why when you come back to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
Works together with the better float comparison down below. They generate random input values, so sometimes you gotta find ones that work.
Rework tests to make use of gtest via ctest.
Closes: https://bugs.gentoo.org/908403
Closes: https://bugs.gentoo.org/910362