Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/assimp: add 5.2.5-r2, add 5.3.1 #34346

Closed
wants to merge 1 commit into from

Conversation

negril
Copy link
Contributor

@negril negril commented Dec 18, 2023

Rework tests to make use of gtest via ctest.

Closes: https://bugs.gentoo.org/908403
Closes: https://bugs.gentoo.org/910362

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @negril
Areas affected: ebuilds
Packages affected: media-libs/assimp

media-libs/assimp: @waebbl, @gentoo/proxy-maint

Linked bugs

Bugs linked: 919896, 910362, 908403


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 18, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-18 15:57 UTC
Newest commit scanned: 54ae174
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/48c985bd38/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-18 16:13 UTC
Newest commit scanned: 2f4772a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6027ca1007/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-19 00:28 UTC
Newest commit scanned: e1f4ef9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/79fdc04358/output.html

media-libs/assimp/assimp-5.2.5-r2.ebuild Outdated Show resolved Hide resolved
media-libs/assimp/assimp-5.2.5-r2.ebuild Outdated Show resolved Hide resolved
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-24 16:18 UTC
Newest commit scanned: be27230
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fa98c77135/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-28 15:29 UTC
Newest commit scanned: 3f6cd42
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/74b07d0261/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-29 10:19 UTC
Newest commit scanned: 16d6e70
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f1a813fa9d/output.html

Rework tests to make use of gtest via ctest.
Some tests generate random input data which might fail on fma-enabled CPUs due to smaller rounding errors on fused operations, so we repeat those
tests until they succeed.

Closes: https://bugs.gentoo.org/908403
Closes: https://bugs.gentoo.org/910362
Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-29 13:59 UTC
Newest commit scanned: 05b6f38
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/139efa2f76/output.html

@@ -0,0 +1,84 @@
diff --git a/include/assimp/matrix3x3.inl b/include/assimp/matrix3x3.inl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you come back to this, please add some explanation to the top. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit-wise floating point number comparison is down right criminal... It's also a wild mix in there so I just use the operators with tolerances.

"^utIssues.OpacityBugWhenExporting_727$"
)
myctestargs+=(
--repeat until-pass:100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deserves a comment above it, please explain why when you come back to this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.
Works together with the better float comparison down below. They generate random input values, so sometimes you gotta find ones that work.

@negril negril deleted the media-libs/assimp/5.3.1 branch January 28, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants