Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-analyzer/traceroute: append lfs flags #34366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taoyl-g
Copy link

@taoyl-g taoyl-g commented Dec 19, 2023

This change adds large file support for traceroute 2.1.3.

Bug: https://bugs.gentoo.org/471102

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @taoyl-g
Areas affected: ebuilds
Packages affected: net-analyzer/traceroute

net-analyzer/traceroute: @gentoo/netmon

Linked bugs

Bugs linked: 471102


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 19, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-19 04:53 UTC
Newest commit scanned: b68fe75
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8e4d3507a4/output.html

@@ -16,6 +16,10 @@ IUSE="static"

RDEPEND="!net-misc/iputils[traceroute6(-)]"

src_configure() {
append-lfs-flags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream has a bug tracker. please file a bug with them and link that here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Btw, I've not fully understood why LFS is relevant with this package - diffing 2.1.0 and 2.1.3 I only see some additional usage of poll(). Is the LFS flags going to affect signature of poll()?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CrOS has exceptions in place for specific versions to force people to clean things up the next time the package is upgraded

This change adds large file support for traceroute 2.1.3.

Bug: https://bugs.gentoo.org/471102
Signed-off-by: Taoyu Li <taoyl@chromium.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-11 03:54 UTC
Newest commit scanned: 25b9af4
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8faa69d5b2/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants