Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/libdnet: switch from use_with to use_enable for tests #34411

Closed
wants to merge 1 commit into from
Closed

dev-libs/libdnet: switch from use_with to use_enable for tests #34411

wants to merge 1 commit into from

Conversation

matoro
Copy link
Contributor

@matoro matoro commented Dec 22, 2023

This is the correct way to do it for all versions tested, otherwise the test suite is a no-op. Tests fail though, see bug 778797.

@matoro
dev-libs/libdnet: switch from use_with to use_enable for tests
656efbf 
This is the correct way to do it for all versions tested, otherwise the
test suite is a no-op.  Tests fail though, see bug 778797.

Bug: https://bugs.gentoo.org/913838
Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @matoro
Areas affected: ebuilds
Packages affected: dev-libs/libdnet

dev-libs/libdnet: @gentoo/netmon

Linked bugs

Bugs linked: 913838

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 22, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-22 04:52 UTC
Newest commit scanned: 656efbf
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7a1f0a4560/output.html

flint2 pushed a commit to flint2/gentoo that referenced this pull request Dec 22, 2023
@matoro @flint2
dev-libs/libdnet: switch from use_with to use_enable for tests
b384a81 
This is the correct way to do it for all versions tested, otherwise the
test suite is a no-op.  Tests fail though, see bug 778797.

Bug: https://bugs.gentoo.org/913838
Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
Closes: gentoo#34411
Signed-off-by: Sam James <sam@gentoo.org>
@krnowak
Copy link
Contributor

krnowak commented Jan 8, 2024

This change broke building libdnet 1.16.2 when libcheck is not available. This version does not recognize --disable-check option and proceeds to check for the check library with pkg-config and bails out if it is not available. The --enable-check option is a new thing in 1.16.4 (see ofalk/libdnet@0cf3d2b)

@matoro
Copy link
Contributor Author

matoro commented Jan 14, 2024

This change broke building libdnet 1.16.2 when libcheck is not available. This version does not recognize --disable-check option and proceeds to check for the check library with pkg-config and bails out if it is not available. The --enable-check option is a new thing in 1.16.4 (see ofalk/libdnet@0cf3d2b)

Gah, OK. I'm just going to drop tests for <1.16.4 then. Sorry for the issue.

@matoro matoro mentioned this pull request Jan 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@matoro @gentoo-bot @gentoo-repo-qa-bot @krnowak