Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-libs/opensubdiv: add 3.5.1, 3.6.0 #34546

Closed
wants to merge 1 commit into from
Closed

media-libs/opensubdiv: add 3.5.1, 3.6.0 #34546

wants to merge 1 commit into from

Conversation

negril
Copy link
Contributor

@negril negril commented Dec 29, 2023

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @negril
Areas affected: ebuilds
Packages affected: media-libs/opensubdiv

media-libs/opensubdiv: @redchillipadi, @gentoo/proxy-maint

Linked bugs

Bugs linked: 835589, 891301, 903982, 884463

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 29, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-29 20:22 UTC
Newest commit scanned: d450b4a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/00f4ca518d/output.html

thesamesam
thesamesam reviewed Jan 20, 2024
View reviewed changes
media-libs/opensubdiv/opensubdiv-3.6.0.ebuild
src_install() {
cmake_src_install

rm -f "${ED}/usr/lib64/libosdCPU.a" || die
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding lib64 is wrong, it should be $(get_libdir). I'll fix it on merge.

@negril negril deleted the media-libs/opensubdiv/3.6.0 branch January 28, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@negril @gentoo-bot @gentoo-repo-qa-bot @thesamesam