Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-lang/julia: update to 1.10.0 #34569

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apraga
Copy link
Contributor

@apraga apraga commented Dec 30, 2023

Hi,

A first stab at 1.10.0. 2 remarks:

  1. Compilation requires librbio.so which is not available by Gentoo's suitesparse. I'm not sure why it's now an issue and could not figure out how to disable it. This PR uses Julia's suitesparse as a fix.
  2. On my machine, there are 2 timeout when merging the ebuild. Running the command manually fixes it so I'm not sure what the issue is:
/var/tmp/portage/dev-lang/julia-1.10.0/work/julia-1.10.0/deps/tools/jldownload "/var/tmp/portage/dev-lang/julia-1.10.0/work/julia-1.10.0/deps/srccache/UnicodeData-13.0.0.txt" https://www.unicode.org/Public/13.0.0/ucd/UnicodeData.txt
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
  Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:04 --:--:--     0curl: (6) Could not resolve host: cache.julialang.org
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
  Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:04 --:--:--     0curl: (6) Could not resolve host: www.unicode.org

and

 Building HTML documentation.
  /var/tmp/portage/dev-lang/julia-1.10.0/work/julia-1.10.0/usr/bin/julia --startup-file=no --color=yes /var/tmp/portage/dev-lang/julia-1.10.0/work/julia-1.10.0/doc/make.jl linkcheck= doctest= buildroot=/var/tmp/portage/dev-lang/julia-1.10.0/work/julia-1.10.0 texplatform= revise=
  Installing known registries into `/var/tmp/portage/dev-lang/julia-1.10.0/work/julia-1.10.0/doc/deps`
  ┌ Warning: could not download https://pkg.julialang.org/registries
  │   exception = RequestError: Could not resolve host: pkg.julialang.org while requesting https://pkg.julialang.org/registries
  └ @ Pkg.Registry /var/tmp/portage/dev-lang/julia-1.10.0/work/julia-1.10.0/usr/share/julia/stdlib/v1.10/Pkg/src/Registry/Registry.jl:69
  ┌ Warning: could not download https://pkg.julialang.org/registries
  │   exception = RequestError: Could not resolve host: pkg.julialang.org while requesting https://pkg.julialang.org/registries
  └ @ Pkg.Registry /var/tmp/portage/dev-lang/julia-1.10.0/work/julia-1.10.0/usr/share/julia/stdlib/v1.10/Pkg/src/Registry/Registry.jl:69
  Cloning registry from "https://github.com/JuliaRegistries/General.git"
  ERROR: LoadError: failed to clone from https://github.com/JuliaRegistries/General.git, error: GitError(Code:ERROR, Class:OS, failed to connect to github.com: Network is unreachable)

Tested with:

  • CairoMakie,GLMakie,AlgebraOfGrahpics (my code)
  • CSV, DataFramesMeta (my code)
  • GTK (the tutorial)
  • DiscreteMarkovChains (the tutorial)

@tamiko @xgqt Any advice would be appreciated !

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @apraga
Areas affected: ebuilds
Packages affected: dev-lang/julia

dev-lang/julia: @tamiko, @gentoo/sci

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Dec 30, 2023
@xgqt
Copy link
Member

xgqt commented Dec 30, 2023

ERROR: LoadError: failed to clone from https://github.com/JuliaRegistries/General.git, error: GitError(Code:ERROR, Class:OS, failed to connect to github.com: Network is unreachable)

You need to either:

  • patch the script that want to clone that repo to skip the clone and ship a repo tarball in SRC_URI
  • disable doc build

@xgqt
Copy link
Member

xgqt commented Dec 30, 2023

Compilation requires librbio.so which is not available by Gentoo's suitesparse. I'm not sure why it's now an issue and could not figure out how to disable it. This PR uses Julia's suitesparse as a fix.

Maybe a bug report should be reported for suitesparse?

@apraga
Copy link
Contributor Author

apraga commented Dec 30, 2023

@xgqt Thanks for your super-quick feedback. Documentation has been disabled and a bug has been submitted for suitesparse : https://bugs.gentoo.org/921100

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-30 21:12 UTC
Newest commit scanned: 68c368c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d1ee7c4ca7/output.html

Copy link
Member

@AndrewAmmerlaan AndrewAmmerlaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Signed-off-by: line to your commit message in accordance to our copyright policy.

Other then the missing || die's this looks good to me. I haven't tested emerging it yet though.

dev-lang/julia/julia-1.10.0.ebuild Outdated Show resolved Hide resolved
dev-lang/julia/julia-1.10.0.ebuild Outdated Show resolved Hide resolved
dev-lang/julia/julia-1.10.0.ebuild Outdated Show resolved Hide resolved
dev-lang/julia/julia-1.10.0.ebuild Outdated Show resolved Hide resolved
Use julia suiteparse as it fails to compile without rbio (not packaged
by Gentoo in sci-libs/suiteparse).

Disabling doc generation due to timeout issues.

Signed-off-by: Alexis Praga <alexis.praga@proton.me>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-10 18:48 UTC
Newest commit scanned: 033b018
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6b112a465f/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-10 19:33 UTC
Newest commit scanned: 7cf4be8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2bc81d0d14/output.html

@apraga
Copy link
Contributor Author

apraga commented Jan 10, 2024

Your suggestions have been added, thanks. The latest version emerge fine on my end.
rbio should be packaged by #34732. Do you want to merge this PR and I'll make another after #34732 is merged ?

@AndrewAmmerlaan
Copy link
Member

Your suggestions have been added, thanks. The latest version emerge fine on my end. rbio should be packaged by #34732. Do you want to merge this PR and I'll make another after #34732 is merged ?

Lets merge #34732 first, so we can add the new julia without bundling suitesparse in one go. This saves a rebuild on the end-users end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
5 participants