Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-editors/jedit: switch to java-pkg-simple.eclass #34579

Closed
wants to merge 1 commit into from

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Dec 31, 2023

Switching from java-ant-2 to java-pkg-simple allows dropping dependency on ant-contrib with further 45 dependencies.

Builds internal documentation with xmltproc populating /usr/share/jedit/lib/doc/{FAQ,tips,users-guide,whatsnew}.

Adds dependency on docbook-xsl-stylesheets which is needed for processing xref in the xml files in the users-guide directory.

Still missing users-guide/toc.xml

Bug: https://bugs.gentoo.org/904034

Switching from java-ant-2 to java-pkg-simple allows dropping
dependency on ant-contrib with further 45 dependencies.

Builds internal documentation with xmltproc populating
/usr/share/jedit/lib/doc/{FAQ,tips,users-guide,whatsnew}.

Adds dependency on docbook-xsl-stylesheets which is needed for
processing xref in the xml files in the users-guide directory.

Still missing users-guide/toc.xml

Bug: https://bugs.gentoo.org/904034
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: app-editors/jedit

app-editors/jedit: @gentoo/java

Linked bugs

Bugs linked: 904034


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 31, 2023
@vaukai vaukai mentioned this pull request Dec 31, 2023
15 tasks
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-31 14:07 UTC
Newest commit scanned: 7462e65
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0af168bb23/output.html

@fordfrog
Copy link
Contributor

fordfrog commented Jan 1, 2024

what the content of that zip file should be? it might be deduced from the build.xml. maybe it just wants to unpack something that we already have in the tree in another package and symlinking the files instead might be enough.

@vaukai
Copy link
Contributor Author

vaukai commented Jan 1, 2024

what the content of that zip file should be? it might be deduced from the build.xml. maybe it just wants to unpack something that we already have in the tree in another package and symlinking the files instead might be enough.

bug 904034 was about the old version built with java-ant-2.

In the new version rewritten using java-pkg-simple the absence of that zip file is solved by BDEPEND on app-text/docbook-xsl-stylesheets:0 and symlinking:

ln -s /usr/share/sgml/docbook/ . || die

After finishing the new version I tried that also with the old version. It took me a tiny step further there but didn't completely solve that bug. I decided to not continue building it with java-ant-2.
A TODO with reference to http://www.sagehill.net/docbookxsl/Xinclude.html#d0e40343 for a future project is commented in the ebuild.
After stabilization of the new version we could probably save some work by making ant-ivy PMASKED together with ant-contrib and if ever needed again, then later re-add apache-ivy with an up-to-date package name.

@gentoo-bot gentoo-bot closed this in 04595b5 Jan 3, 2024
@fordfrog
Copy link
Contributor

fordfrog commented Jan 3, 2024

After stabilization of the new version we could probably save some work by making ant-ivy PMASKED together with ant-contrib and if ever needed again, then later re-add apache-ivy with an up-to-date package name.

ivy is an end user tool so it would be better to preserve it.

@vaukai vaukai deleted the jedit branch January 3, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants