Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-libs/libvncserver: always enable gcrypt-based crypto backend #34643

Closed

Conversation

puleglot
Copy link
Contributor

@puleglot puleglot commented Jan 4, 2024

net-libs/libvncserver: always enable gcrypt-based crypto backend

There are a few reasons for that:

  • internal crypto backend doesn't support all authentication methods and the use of external crypto backend was already forced via REQUIRED_USE
  • openssl-based crypto backend is completely broken with openssl-3.0
  • build system does not allow to disable openssl-based crypto backend when openssl-based TLS backend is enabled without also enabling gcrypt-based crypto backend
  • all major distros are building with gcrypt-based crypto backend, so it is the most tested configuration.

Closes: https://bugs.gentoo.org/893608

There are a few reasons for that:
- internal crypto backend doesn't support all authentication methods and
  the use of external crypto backend was already forced via REQUIRED_USE
- openssl-based crypto backend is completely broken with openssl-3.0
- build system does not allow to disable openssl-based crypto backend when
  openssl-based TLS backend is enabled without also enabling gcrypt-based
  crypto backend
- all major distros are building with gcrypt-based crypto backend, so it
  is the most tested configuration.

Closes: https://bugs.gentoo.org/893608
Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @puleglot
Areas affected: ebuilds
Packages affected: net-libs/libvncserver

net-libs/libvncserver: @puleglot, @gentoo/proxy-maint

Linked bugs

Bugs linked: 893608


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 4, 2024
Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
@puleglot puleglot force-pushed the libvncserver-always-enable-gcrypt branch from b6709be to 2968837 Compare January 4, 2024 19:48
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-04 20:02 UTC
Newest commit scanned: 2968837
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fa16965e05/output.html

@puleglot puleglot deleted the libvncserver-always-enable-gcrypt branch January 23, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
3 participants