net-libs/glib-networking: Allow to select openssl instead of gnutls #34746
Conversation
Pull Request assignmentSubmitter: @lanodan net-libs/glib-networking: @gentoo/gnome Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2024-01-11 11:07 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
This change really deserves more in the commit message at minimum.
Per https://gitlab.gnome.org/GNOME/glib-networking/-/blob/master/meson_options.txt#L1, this is only provided for licencing reasons, and isn't recommended. That deserves at least some acknowledgement in the commit message and perhaps a comment in the ebuild too.
Please also see (and tag) https://bugs.gentoo.org/827206.
| IUSE="+gnome +gnutls openssl +libproxy +ssl test" | ||
| RESTRICT="!test? ( test )" | ||
| REQUIRED_USE="ssl? ( || ( gnutls openssl ) )" | ||
| KEYWORDS="~alpha amd64 arm arm64 ~hppa ~ia64 ~loong ~mips ppc ppc64 ~riscv ~s390 ~sparc x86 ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x64-solaris" |
lanodan
force-pushed
the
glib-networking-openssl
branch
from
acb10fc
to
d8fe174
Compare
About the experimental status: Been using the openssl backend for some years in my overlay now with webkit-gtk, you get worse error handling but also less errors overall. Closes: https://bugs.gentoo.org/827206 Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
lanodan
force-pushed
the
glib-networking-openssl
branch
from
d8fe174
to
94dba87
Compare
|
Added a bit of background in the commit message and noted it as experimental in metadata.xml.
(Also addressed the keywords)
|
Pull request CI reportReport generated at: 2024-01-14 16:58 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Due to it being purely for licensing and heavy warnings from upstream to not really use it as it's worse, I did not wire up back then very much on purpose. |
Signed-off-by: Haelwenn (lanodan) Monnier contact@hacktivis.me