Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-vim/{colorschemes,molokai,zenburn}: add blockers #34788

Closed
wants to merge 3 commits into from
Closed

app-vim/{colorschemes,molokai,zenburn}: add blockers #34788

wants to merge 3 commits into from

Conversation

mm1ke
Copy link
Contributor

@mm1ke mm1ke commented Jan 13, 2024 •
edited

app-vim/colorschemes comes with molokai and zenburn includes, thus adding blockers to prevent file collision.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 13, 2024
@mm1ke mm1ke changed the title app-vim/{colorschemes,molokai}: add blockers app-vim/{colorschemes,molokai,zenburn}: add blockers Jan 13, 2024
@mm1ke mm1ke changed the title app-vim/{colorschemes,molokai,zenburn}: add blockers [please reassign] app-vim/{colorschemes,molokai,zenburn}: add blockers Jan 13, 2024
@gentoo-bot gentoo-bot changed the title [please reassign] app-vim/{colorschemes,molokai,zenburn}: add blockers app-vim/{colorschemes,molokai,zenburn}: add blockers Jan 13, 2024
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mm1ke
Areas affected: ebuilds
Packages affected: app-vim/colorschemes, app-vim/molokai, app-vim/zenburn

app-vim/colorschemes: @gentoo/vim
app-vim/molokai: @gentoo/vim
app-vim/zenburn: @gentoo/vim, @monsieurp

Linked bugs

Bugs linked: 637122, 585332

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 13, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-13 17:23 UTC
Newest commit scanned: 782bd5b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bc29b66953/output.html

ConiKost
ConiKost suggested changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@ConiKost ConiKost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since RDEPEND is being touched, this should be revbumped.

@mm1ke
app-vim/colorschemes: add blockers to app-vim/molokai and app-vim/zen…
b4bc04e 
…burn

Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>
@mm1ke
app-vim/molokai: add blocker to app-vim/colorschemes
a4e8c82 
Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>

Closes: https://bugs.gentoo.org/637122
@mm1ke
app-vim/zenburn: add blocker to app-vim/colorschemes
56b6134 
Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>

Closes: https://bugs.gentoo.org/585332
@mm1ke
Copy link
Contributor Author

mm1ke commented Jan 14, 2024

I've updated the PR and made a revbump but i kept the KEYWORDS - hope thats fine

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-14 10:54 UTC
Newest commit scanned: 56b6134
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3c240f89f0/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConiKost ConiKost ConiKost requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@mm1ke @gentoo-bot @gentoo-repo-qa-bot @ConiKost