Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/libbsb: EAPI8 bump, fix bug #724744 #34842

Closed
wants to merge 1 commit into from

Conversation

mm1ke
Copy link
Contributor

@mm1ke mm1ke commented Jan 16, 2024

This fixes calling ar directly, bug #724744.
While looking at the build log i've also encounter the QA Warning mentioned in bug #899814
However, i've noticed that after using eautoreconf the QA Warning is gone - the wiki guide mentioned that this could fix it - which is why i've marked this bug as fixed too..

--- libbsb-0.0.7-r1.ebuild	2023-11-15 17:01:28.645049560 +0100
+++ libbsb-0.0.7-r2.ebuild	2024-01-16 20:40:57.367257438 +0100
@@ -1,16 +1,17 @@
-# Copyright 1999-2022 Gentoo Authors
+# Copyright 1999-2024 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
-EAPI=7
+EAPI=8
 
-DESCRIPTION="A portable C library for reading and writing BSB format image files"
-HOMEPAGE="http://libbsb.sourceforge.net/"
+inherit autotools toolchain-funcs
+
+DESCRIPTION="Portable C library for reading and writing BSB format image files"
+HOMEPAGE="https://libbsb.sourceforge.net/"
 SRC_URI="mirror://sourceforge/${PN}/${P}.tar.gz"
 
-LICENSE="LGPL-2.1"
+LICENSE="LGPL-2.1+"
 SLOT="0"
-KEYWORDS="amd64 x86"
-IUSE=""
+KEYWORDS="~amd64 ~x86"
 
 DEPEND="media-libs/libpng
 	media-libs/tiff:="
@@ -20,4 +21,8 @@
 # tools work perfectly, so restrict test until this is fixed upstream
 RESTRICT="test"
 
-DOCS=( README AUTHORS )
+src_prepare(){
+	sed -i -e "s|ar crv|$(tc-getAR) crv|" Makefile.am || die
+	default
+	eautoreconf
+}

Signed-off-by: Michael Mair-Keimberger mmk@levelnine.at

Closes: https://bugs.gentoo.org/724744
Closes: https://bugs.gentoo.org/899814

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mm1ke
Areas affected: ebuilds
Packages affected: media-libs/libbsb

media-libs/libbsb: @mschiff

Linked bugs

Bugs linked: 724744, 899814


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 16, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-16 20:23 UTC
Newest commit scanned: 1d1a7fb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/293738242c/output.html

@ConiKost ConiKost requested a review from mschiff January 20, 2024 22:07
@mm1ke mm1ke force-pushed the libb-oZeiKi4m branch 2 times, most recently from 2ec9fe3 to 679bd79 Compare February 7, 2024 18:24
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-07 18:53 UTC
Newest commit scanned: 679bd79
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0336faca4f/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-17 09:58 UTC
Newest commit scanned: e91c0dc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c362e05818/output.html

Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>

Closes: https://bugs.gentoo.org/724744
Closes: https://bugs.gentoo.org/899814
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-04 18:32 UTC
Newest commit scanned: 5aa1212
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/47166cf287/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
3 participants