Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ostinato to 1.3.0 #34894

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update ostinato to 1.3.0 #34894

wants to merge 3 commits into from
+45 −0

Conversation

lordrasmus
Copy link

No description provided.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @lordrasmus
Areas affected: ebuilds
Packages affected: net-analyzer/ostinato

net-analyzer/ostinato: @ZeroChaos-

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Jan 19, 2024
mm1ke
mm1ke reviewed Jan 19, 2024
View reviewed changes
net-analyzer/ostinato/ostinato-1.3.0.ebuild Outdated
HOMEPAGE="https://ostinato.org/"
SRC_URI="https://github.com/pstavirs/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz"

LICENSE="GPL-3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be GPL-3+, see: https://github.com/pstavirs/ostinato/blob/master/client/main.cpp#L6-L9

mm1ke
mm1ke reviewed Jan 19, 2024
View reviewed changes
net-analyzer/ostinato/ostinato-1.3.0.ebuild Outdated
LICENSE="GPL-3"
SLOT="0"
KEYWORDS="~amd64 ~arm ~x86"
IUSE=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty IUSE could be removed.

mm1ke
mm1ke reviewed Jan 19, 2024
View reviewed changes
net-analyzer/ostinato/ostinato-1.3.0.ebuild Outdated

src_install() {
emake INSTALL_ROOT="${ED}" install
mv "${ED}"/usr/bin/{drone,ostinato-drone}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing || die

@lordrasmus
Copy link
Author

i just renamed the 1.2.0 file

but i can change that

@mm1ke
Copy link
Contributor

mm1ke commented Jan 19, 2024

i just renamed the 1.2.0 file

but i can change that

No problem. I just try to help with improving the ebuilds. :)
A few notes to your PR:

  • please create separate branches for each PR. There is a good wiki page on how to create a proper PR for gentoo. Have a look at: https://wiki.gentoo.org/wiki/GitHub_Pull_Requests
  • when you make changes to the PR (like the changes i've asked for) you can usually squash them into one commit.
  • also you need to add your Signed-off-by to your PRs (that's why it's labled "no signoff" right now) - again please have a look at the wiki page
  • the ci also shows you that there are unnecessary files in Manifest. Don't know how they got added, but ebuilds are not included in the Manifest. In general, i suggest you to use ebuild ... manifest or pkgdev manifest in order to fix that. (pkgdev is part of dev-util/pkgdev)

Finally, you added the missing || die to the emake command, but actually i meant it should be added to the mv command, so it should look like this:

emake INSTALL_ROOT="${ED}" install
mv "${ED}"/usr/bin/{drone,ostinato-drone} || die

@lordrasmus
net-analyzer/ostinato: update to 1.3.0
ee32ae5 
Signed-off-by: Ramin Moussavi <lordrasmus@gmail.com>
@lordrasmus
Copy link
Author

I used the pkgdev manifest, and it added the Ebuild files. I thought it would be okay if the tool does it.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-19 17:48 UTC
Newest commit scanned: ee32ae5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5bcd209b96/output.html

@vaukai
Copy link
Contributor

vaukai commented Mar 21, 2024

I used the pkgdev manifest, and it added the Ebuild files. I thought it would be okay if the tool does it.

this could and should be avoided using thin-manifests.

Does 1.3.0 solve any of https://bugs.gentoo.org/912829 or https://bugs.gentoo.org/913106?
If so, pls add them to the commit message (can be done with git commit --amend) like

Bug: https://bugs.gentoo.org/912829
Bug: https://bugs.gentoo.org/913106
Closes: https://bugs.gentoo.org/922304

vaukai pushed a commit to vaukai/gentoo that referenced this pull request Mar 21, 2024
@lordrasmus @vaukai
net-analyzer/ostinato: update to 1.3.0
ea01f3b 
Signed-off-by: Ramin Moussavi <lordrasmus@gmail.com>
Closes: gentoo#34894
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
vaukai
vaukai reviewed Mar 21, 2024
View reviewed changes
net-analyzer/ostinato/ostinato-1.3.0.ebuild Outdated
#https://github.com/pstavirs/ostinato/issues/173
# libpcap dep is versioned to pull in the fix for #602098
RDEPEND="
dev-libs/protobuf:=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<dev-libs/protobuf-22.5:=

See https://bugs.gentoo.org/912829 and https://bugs.gentoo.org/913106

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to build with glibc 2.38

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-26 12:10 UTC
Newest commit scanned: 2b7be03
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2fba5a2f9d/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-26 12:50 UTC
Newest commit scanned: fc225f0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/930805f67b/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm1ke mm1ke mm1ke left review comments

@vaukai vaukai vaukai left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
Milestone
No milestone
5 participants
@lordrasmus @gentoo-bot @mm1ke @gentoo-repo-qa-bot @vaukai