Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-p2p/qbittorrent: add 4.6.3 #34917

Closed
wants to merge 3 commits into from
Closed

net-p2p/qbittorrent: add 4.6.3 #34917

wants to merge 3 commits into from

Conversation

stkw0
Copy link
Contributor

@stkw0 stkw0 commented Jan 20, 2024

Also:

  • add myself as a maintainer
  • drop 4.6.0

Signed-off-by: David Roman <davidroman96@gmail.com>
The referenced issue was fixed in 4.6.1

Closes: https://bugs.gentoo.org/917165
Signed-off-by: David Roman <davidroman96@gmail.com>
Signed-off-by: David Roman <davidroman96@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @stkw0
Areas affected: ebuilds
Packages affected: net-p2p/qbittorrent

net-p2p/qbittorrent: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 917165


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 20, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-20 13:43 UTC
Newest commit scanned: 85123cd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/87ca46c093/output.html

@thesamesam
Copy link
Member

thesamesam commented Jan 22, 2024

See also #34949. I'm inclined to merge the other one as yours would be easier to then rebase.

@stkw0
Copy link
Contributor Author

stkw0 commented Jan 22, 2024

I see. Then I will close this PR as this was mostly superseded by the other one. btw bug https://bugs.gentoo.org/917165 should be closed I think, given that the ebuild containing the issue has been removed from the tree.

@stkw0 stkw0 closed this Jan 22, 2024
@thesamesam
Copy link
Member

You're still free to adopt the package with Eli though.

@stkw0
Copy link
Contributor Author

stkw0 commented Jan 22, 2024

Thanks. Maybe in a future I will. If the other person is already active we would need to coordinate to avoid making two times the same PR, etc. So, for now I think it's easier to let the other maintainer take care of it.

@eli-schwartz
Copy link
Contributor

Hmm, really that bug report should have been closed when 4.6.1 was added to the tree on the grounds that it was fixed at that time.

The existence of an older ebuild with the bug still there doesn't mean the bug wasn't fixed. :)

@stkw0
Copy link
Contributor Author

stkw0 commented Jan 22, 2024

I think that, if an older ebuild has a known issue that can be hit by a user, makes sense to keep the bug open (even more if the ebuild references a specific version). Obviously, it would be better to fix the ebuild or drop it instead of keeping a buggy version when a new one doesn't has that problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
5 participants