Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-util/open-vcdiff: EAPI8 bump, fix bug 804447 #35018

Closed
wants to merge 1 commit into from
Closed

dev-util/open-vcdiff: EAPI8 bump, fix bug 804447 #35018

wants to merge 1 commit into from

Conversation

mm1ke
Copy link
Contributor

@mm1ke mm1ke commented Jan 25, 2024

Another EAPI8 bump.
I've also removed src_configure since --disable-static is used with EAPI8 anyway.

Signed-off-by: Michael Mair-Keimberger mmk@levelnine.at

Closes: https://bugs.gentoo.org/804447

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mm1ke
Areas affected: ebuilds
Packages affected: dev-util/open-vcdiff

dev-util/open-vcdiff: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 804447

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 25, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-25 19:52 UTC
Newest commit scanned: 473142f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/659ad4b015/output.html

@mm1ke mm1ke force-pushed the open-sei9Uw5o branch 2 times, most recently from 17b306b to bebb276 Compare February 7, 2024 18:24
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-07 19:23 UTC
Newest commit scanned: bebb276
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b8291b7365/output.html

arthurzam
arthurzam suggested changes Feb 7, 2024
View reviewed changes
dev-util/open-vcdiff/open-vcdiff-0.8.4-r1.ebuild Outdated
econf --disable-static
src_prepare() {
sed -i -e "s|^docdir =.*|docdir = \"${EPREFIX}/usr/share/doc/${PF}\"|g" \
Makefile.in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing || die

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, fixed :)

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-08 20:13 UTC
Newest commit scanned: 0ddb4be
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3eec38a462/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-17 10:28 UTC
Newest commit scanned: 5798dd9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/506935697d/output.html

@mm1ke
dev-util/open-vcdiff: EAPI8 bump, fix bug 804447
e38bedc 
Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>

Closes: https://bugs.gentoo.org/804447
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-04 19:04 UTC
Newest commit scanned: e38bedc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/74706a40e7/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurzam arthurzam arthurzam requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@mm1ke @gentoo-bot @gentoo-repo-qa-bot @arthurzam