Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-util/maxcso: build with app-arch/libdeflate #35035

Closed
wants to merge 1 commit into from
Closed

dev-util/maxcso: build with app-arch/libdeflate #35035

wants to merge 1 commit into from

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Jan 27, 2024

Upstream now supports an external libdeflate.

Upstream-PR: unknownbrackets/maxcso#83
Upstream-Commit: unknownbrackets/maxcso@4949344

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @orbea
Areas affected: ebuilds
Packages affected: dev-util/maxcso

dev-util/maxcso: @orbea, @thesamesam

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jan 27, 2024
@thesamesam
Copy link
Member

CI is fixed, please rebase.

@orbea
dev-util/maxcso: build with app-arch/libdeflate
3f2ac3e 
Upstream now supports an external libdeflate.

Upstream-PR: unknownbrackets/maxcso#83
Upstream-Commit: unknownbrackets/maxcso@4949344
Signed-off-by: orbea <orbea@riseup.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-27 13:48 UTC
Newest commit scanned: 3f2ac3e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bd2ce50efa/output.html

ceamac
ceamac approved these changes Feb 23, 2024
View reviewed changes
dev-util/maxcso/maxcso-9999.ebuild
app-arch/libdeflate:=[zlib]
app-arch/lz4:=
dev-libs/libuv:=
sys-libs/zlib:=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sys-libs/zlib:=
sys-libs/zlib

zlib is the one exception

dev-util/maxcso/maxcso-9999.ebuild
app-arch/lz4
dev-libs/libuv
sys-libs/zlib
app-arch/libdeflate:=[zlib]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
app-arch/libdeflate:=[zlib]
app-arch/libdeflate[zlib]

No subslots here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wasn't sure if it may be needed in the future or not.

@orbea orbea deleted the maxcso-libdeflate branch February 23, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceamac ceamac ceamac approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
5 participants
@orbea @gentoo-bot @thesamesam @gentoo-repo-qa-bot @ceamac