-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-libs/tree-sitter: Version bump to 0.20.9 #35040
Conversation
And some patch rebasing. Closes: https://bugs.gentoo.org/922963 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
Pull Request assignmentSubmitter: @listout dev-libs/tree-sitter: @thrifty-txt, @sarnex, @msva, @MatthewGentoo Linked bugsBugs linked: 922963 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2024-01-27 09:08 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Not sure about removing static linkng part. IIRC, it was kept for reason, but I can't remember why. Other than that - LGTM |
@msva If you mean the tree-sitter-9999-No-static-libs-gentoo patch, I had to do it as the Makefile as has changed, the patch needed to be rebased. Other than that the tree-sitter-No-static-libs-gentoo patch has been accepted, hence removed/is not needed. |
We avoid static linking in Gentoo (https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0302). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I've merged this with a couple of changes.
# match the release. | ||
# ref: https://github.com/tree-sitter/tree-sitter/issues/2210 | ||
# see Makefile:1 | ||
QA_PKGCONFIG_VERSION="0.20.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like upstream are still a version ahead here.
QA_PKGCONFIG_VERSION="0.20.9" | |
QA_PKGCONFIG_VERSION="0.20.10" |
SLOT="0" | ||
|
||
PATCHES=( | ||
"${FILESDIR}/${PN}-9999-No-static-libs-gentoo.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed this file to include the version number in the file name.
"${FILESDIR}/${PN}-9999-No-static-libs-gentoo.patch" | |
"${FILESDIR}/${PN}-0.20.9-no-static.patch" |
Please bump -cli. |
And some patch rebasing.
Closes: https://bugs.gentoo.org/922963