Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-libs/tree-sitter: Version bump to 0.20.9 #35040

Closed
wants to merge 1 commit into from

Conversation

listout
Copy link
Contributor

@listout listout commented Jan 27, 2024

And some patch rebasing.

Closes: https://bugs.gentoo.org/922963

And some patch rebasing.

Closes: https://bugs.gentoo.org/922963
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: dev-libs/tree-sitter

dev-libs/tree-sitter: @thrifty-txt, @sarnex, @msva, @MatthewGentoo

Linked bugs

Bugs linked: 922963


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 27, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-27 09:08 UTC
Newest commit scanned: 230a5a8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bb6dca0683/output.html

@msva
Copy link
Contributor

msva commented Jan 27, 2024

Not sure about removing static linkng part.

IIRC, it was kept for reason, but I can't remember why.

Other than that - LGTM

@listout
Copy link
Contributor Author

listout commented Jan 27, 2024

@msva If you mean the tree-sitter-9999-No-static-libs-gentoo patch, I had to do it as the Makefile as has changed, the patch needed to be rebased.

Other than that the tree-sitter-No-static-libs-gentoo patch has been accepted, hence removed/is not needed.

@thesamesam
Copy link
Member

We avoid static linking in Gentoo (https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0302).

Copy link
Member

@MatthewGentoo MatthewGentoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I've merged this with a couple of changes.

# match the release.
# ref: https://github.com/tree-sitter/tree-sitter/issues/2210
# see Makefile:1
QA_PKGCONFIG_VERSION="0.20.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like upstream are still a version ahead here.

Suggested change
QA_PKGCONFIG_VERSION="0.20.9"
QA_PKGCONFIG_VERSION="0.20.10"

SLOT="0"

PATCHES=(
"${FILESDIR}/${PN}-9999-No-static-libs-gentoo.patch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed this file to include the version number in the file name.

Suggested change
"${FILESDIR}/${PN}-9999-No-static-libs-gentoo.patch"
"${FILESDIR}/${PN}-0.20.9-no-static.patch"

@thesamesam
Copy link
Member

dev-libs/tree-sitter:0

  (dev-libs/tree-sitter-0.20.9:0/0::gentoo, ebuild scheduled for merge) USE="" ABI_X86="(64)" conflicts with
    ~dev-libs/tree-sitter-0.20.8 required by (dev-util/tree-sitter-cli-0.20.8-3:0/0::gentoo, installed) USE="-debug" ABI_X86="(64)"
    ^                     ^^^^^^

Please bump -cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
6 participants