Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles/package.mask: Last rite dev-java/icedtea{,-bin} #35041

Closed
wants to merge 3 commits into from

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Jan 27, 2024

No description provided.

@vaukai vaukai marked this pull request as draft January 27, 2024 09:21
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds, eclasses
Packages affected: dev-java/icedtea, dev-lang/scala

dev-java/icedtea: gnu_andrew[at]member.fsf.org, @gyakovlev, @gentoo/java, @gentoo/proxy-maint
dev-lang/scala: @gentoo/java

Linked bugs

Bugs linked: 857264


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 27, 2024
@vaukai vaukai force-pushed the EAPI6 branch 7 times, most recently from 7eaa550 to 560227c Compare January 28, 2024 11:49
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-28 12:08 UTC
Newest commit scanned: 560227c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/88262a306d/output.html

@vaukai vaukai force-pushed the EAPI6 branch 3 times, most recently from ee9d7ef to 8a5d9d1 Compare February 7, 2024 08:09
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-07 08:22 UTC
Newest commit scanned: 8a5d9d1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/87beb1d63d/output.html

@vaukai vaukai changed the title java-{pkg,utils}-2.eclass: drop EAPI 6 profiles/package.mask: Last rite dev-java/icedtea{,-bin} | java-{pkg,utils}-2.eclass: drop EAPI 6 Feb 14, 2024
@vaukai vaukai marked this pull request as ready for review February 14, 2024 11:13
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@vaukai vaukai force-pushed the EAPI6 branch 3 times, most recently from 3c71d58 to 48145ce Compare February 14, 2024 12:56
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@vaukai vaukai force-pushed the EAPI6 branch 3 times, most recently from 0002db4 to d63ad3b Compare February 14, 2024 17:37
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@vaukai vaukai changed the title profiles/package.mask: Last rite dev-java/icedtea{,-bin} | java-{pkg,utils}-2.eclass: drop EAPI 6 profiles/package.mask: Last rite dev-java/icedtea{,-bin} Feb 14, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-14 18:38 UTC
Newest commit scanned: 70a1f95
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/ecfcbb2cae/output.html#virtual/jdk

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ecfcbb2cae/output.html

@vaukai vaukai deleted the EAPI6 branch February 16, 2024 11:39
@vaukai vaukai restored the EAPI6 branch February 16, 2024 13:11
@vaukai vaukai deleted the EAPI6 branch February 16, 2024 13:24
@gnu-andrew
Copy link
Contributor

Is the intention to drop 8u support from Gentoo?
Otherwise it's not clear why you would drop IcedTea but keep a version of 8u with fewer features (e.g. no Shenandoah, no arm32 support) and questionable changes such as this commit: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=250d2f45f958ccb2a4e3c437d396b88f5d3bd59e

@vaukai
Copy link
Contributor Author

vaukai commented Mar 26, 2024

Is the intention to drop 8u support from Gentoo? Otherwise it's not clear why you would drop IcedTea but keep a version of 8u with fewer features (e.g. no Shenandoah, no arm32 support) and questionable changes such as this commit: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=250d2f45f958ccb2a4e3c437d396b88f5d3bd59e

@gnu-andrew
Copy link
Contributor

Is the intention to drop 8u support from Gentoo? Otherwise it's not clear why you would drop IcedTea but keep a version of 8u with fewer features (e.g. no Shenandoah, no arm32 support) and questionable changes such as this commit: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=250d2f45f958ccb2a4e3c437d396b88f5d3bd59e

* Due to lack of maintainer capacity it was intended to last-rite them both, see https://gitweb.gentoo.org/repo/gentoo.git/commit/profiles/package.mask?id=9d1c2c7c952dbd66c6594a3ed8ebd648b69e6fab

* Then there was [bug 924945](https://bugs.gentoo.org/924945)

* And then, only and really only because there was/is no `openjdk-bin:8` for `x86`, we concluded to keep the `-bin`: https://gitweb.gentoo.org/repo/gentoo.git/commit/profiles/package.mask?id=c75dc8a3278096459ed73e2bae27441175efb8e4

Ok, thanks. Well that explains why I didn't need to unmask icedtea-bin to bootstrap, but not whether 8u support as a whole is to be continued. I would be happy to maintain dev-java/icedtea as I did before, but there is not much point if the intent is to remove virtual/jdk-1.8.0 and dev-java/openjdk:8 in the near term as well.

I managed to build the current dev-java/icedtea fine yesterday. I looked through the list of bugs and most of them go back years, and would likely apply to dev-java/openjdk:8 too (IcedTea being a wrapper and extension of the same sources). Some are just requesting updates which would be resolved by bumping to the latest, which should be fairly trivial. Are there particular bugs that were blockers for IcedTea remaining in the distro or was it just the general lack of a maintainer?

I've never maintained icedtea-bin and I'm not sure how those binaries were created. Yesterday is actually the first time I used it at all, as I used to bootstrap via gcj -> IcedTea for OpenJDK 6 or 7 -> IcedTea for OpenJDK 8. It looks like Adoptium have x86 binaries for 8u so maybe this could just be added to openjdk-bin and icedtea-bin dropped?

@gnu-andrew
Copy link
Contributor

PR to bump to 3.30: #35942

@vaukai
Copy link
Contributor Author

vaukai commented Mar 27, 2024

It looks like Adoptium have x86 binaries for 8u so maybe this could just be added to openjdk-bin and icedtea-bin dropped?

That link goes to Operating System Windows. Can Windows binaries be used for Linux?

@fordfrog
Copy link
Contributor

just with regard to removal of java 8 from gentoo, that should not happen for quite some time yet. the official eol for java 8 is 2030-12-31

@gnu-andrew
Copy link
Contributor

It looks like Adoptium have x86 binaries for 8u so maybe this could just be added to openjdk-bin and icedtea-bin dropped?

That link goes to Operating System Windows. Can Windows binaries be used for Linux?

Ah, I missed that. I thought it was showing only the OS I was on. It looks like they don't support it: adoptium/adoptium-support#521 Sorry for the noise

It looks like Azul are the only vendor to offer x86_32 Linux:

https://adoptium.net/marketplace/?arch=x86&version=8
https://www.azul.com/downloads/?version=java-8-lts&os=linux&architecture=x86-32-bit&package=jdk#zulu

@gnu-andrew
Copy link
Contributor

just with regard to removal of java 8 from gentoo, that should not happen for quite some time yet. the official eol for java 8 is 2030-12-31

That's for the proprietary Oracle JDK. When OpenJDK 8u support ends will depend on the OpenJDK community.

@vaukai
Copy link
Contributor Author

vaukai commented Mar 27, 2024

It looks like Azul are the only vendor to offer x86_32 Linux:

https://adoptium.net/marketplace/?arch=x86&version=8 https://www.azul.com/downloads/?version=java-8-lts&os=linux&architecture=x86-32-bit&package=jdk#zulu

Created https://bugs.gentoo.org/927961 for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants