Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-util/pycharm-professional: add 2023.3.3 #35082

Closed
wants to merge 2 commits into from
Closed

dev-util/pycharm-professional: add 2023.3.3 #35082

wants to merge 2 commits into from

Conversation

parona-source
Copy link
Contributor

No description provided.

@parona-source
dev-util/pycharm-professional: add 2023.3.3
2fdfc1d 
* Add license of bundled dependencies.
* Drop x86 as compatible libraries aren't included.
* Finally handle noise from prebuilt libraries.
* Remove README which is outdated, nowadays JetBrains prefers their own
  fork of OpenJDK over Oracle JDK.

Bug: https://bugs.gentoo.org/694272
Bug: https://bugs.gentoo.org/914287
Bug: https://bugs.gentoo.org/914285
Bug: https://bugs.gentoo.org/914286
Signed-off-by: Alfred Wingate <parona@protonmail.com>
@parona-source
dev-util/pycharm-professional: drop versions
124a182 
Signed-off-by: Alfred Wingate <parona@protonmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @parona-source
Areas affected: ebuilds
Packages affected: dev-util/pycharm-professional

dev-util/pycharm-professional: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 694272, 914285, 914286, 914287

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 29, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-29 20:03 UTC
Newest commit scanned: 124a182
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5ebedd6680/output.html

juippis
juippis approved these changes Feb 24, 2024
View reviewed changes
dev-util/pycharm-professional/pycharm-professional-2023.3.3.ebuild
bin/idea.properties || die

if ! use bundled-jdk; then
rm -rf jbr || die
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally don't use -f if the file path is predictable. Otherwise this will never fail and therefore will never be updated in the ebuild, if it changes by upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@parona-source @gentoo-bot @gentoo-repo-qa-bot @juippis