Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www-client/chromium, chrome, edge: updates #35111

Closed
wants to merge 9 commits into from

Conversation

Kangie
Copy link
Contributor

@Kangie Kangie commented Jan 31, 2024

In addition to standard ebuild maintenance, this PR adds proper support for building with a reduced patchset,
using the Google-provided toolchain (USE="-system-toolchain").

It's not going to be nearly as flexible as using the system toolchain, but will help to future-proof us against
the use of prerelease clang or rust features in a stable ebuild.

This ebuild adds support for building with a reduced patchset,
using the Google toolchain. It's not going to be nearly as flexible
as using the system toolchain, but will help to future-proof us against
the use of prerelease clang or rust features in a stable ebuild.

Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
@Kangie Kangie changed the title Chromium 122 bundled toolchain www-client/chromium, chrome, edge: updates Jan 31, 2024
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jan 31, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-31 06:23 UTC
Newest commit scanned: 5304d7e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a4719c5a01/output.html

This ebuild adds support for building with a reduced patchset,
using the Google toolchain. It's not going to be nearly as flexible
as using the system toolchain, but will help to future-proof us against
the use of prerelease clang or rust features in a stable ebuild.

Bug: https://bugs.gentoo.org/923370
Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
Bug: https://bugs.gentoo.org/923370
Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
@Kangie Kangie changed the title www-client/chromium, chrome, edge: updates www-client/chromium, chrome, edge: updates [please reassign] Jan 31, 2024
@Kangie Kangie force-pushed the chromium-122-bundled-toolchain branch from 5304d7e to 4bde6e6 Compare January 31, 2024 06:51
@gentoo-bot gentoo-bot changed the title www-client/chromium, chrome, edge: updates [please reassign] www-client/chromium, chrome, edge: updates Jan 31, 2024
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Kangie
Areas affected: ebuilds, profiles
Packages affected: www-client/chromium, www-client/google-chrome, www-client/microsoft-edge-dev, www-plugins/chrome-binary-plugins

www-client/chromium: @gentoo/chromium, Matt.Jolly[at]footclan.ninja
www-client/google-chrome: @gentoo/chromium
www-client/microsoft-edge-dev: @gentoo/chromium
www-plugins/chrome-binary-plugins: @gentoo/chromium

Linked bugs

Bugs linked: 923370


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. security PR that needs to be merged promptly as it addresses security issues and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jan 31, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-31 07:23 UTC
Newest commit scanned: 4bde6e6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fc604f6572/output.html

# The sysroot is the oldest debian image that chromium supports, we don't need it
myconf_gn+=" use_sysroot=false"

# This determines whether or not GN uses the bundled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost a word?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. security PR that needs to be merged promptly as it addresses security issues
Projects
None yet
4 participants