Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump alsa packages to 1.2.11 #35146

Closed
wants to merge 3 commits into from

Conversation

vadorovsky
Copy link
Contributor

@vadorovsky vadorovsky commented Feb 2, 2024

Bump

  • media-libs/alsa-lib
  • media-sound/alsa-tools
  • media-sound/alsa-utils

to 1.2.11. See the commit messages for details.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vadorovsky
Areas affected: ebuilds
Packages affected: media-libs/alsa-lib

media-libs/alsa-lib: [alsa-bugs (project)]

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits. labels Feb 2, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-02 14:28 UTC
Newest commit scanned: 7932cbc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6507cd90c5/output.html

@thesamesam
Copy link
Member

The whole ALSA stack should be done together (same PR, sep commits)

@vadorovsky vadorovsky changed the title media-libs/alsa-lib: Bump alsa-lib to 1.2.11 Bump alsa packages to 1.2.11 Feb 3, 2024
@vadorovsky vadorovsky marked this pull request as draft February 3, 2024 12:04
@vadorovsky
Copy link
Contributor Author

vadorovsky commented Feb 3, 2024

@thesamesam OK, I think I bumped all alsa packages which are affected by 1.2.11 update. Are you fine with the PR desc and commit messages?

I marked as a draft, because I still want to test it properly today, I will ping you once I'm ready.

@thesamesam
Copy link
Member

@thesamesam OK, I think I bumped all alsa packages which are affected by 1.2.11 update. Are you fine with the PR desc and commit messages?

They look good! Thank you.

Just remember to ekeyword ~all ... which should fix the CI failure (see https://devmanual.gentoo.org/keywording/index.html#keywording-on-upgrades).

I marked as a draft, because I still want to test it properly today, I will ping you once I'm ready.

@vadorovsky
Copy link
Contributor Author

@thesamesam Alright, all packages work for me and I updated the keywords. Thanks for review!

@thesamesam
Copy link
Member

Will review later on, thanks! Could you rebase one more time, as I've just fixed the CI failure?

Changes:
- Version bump to 1.2.11
- Add an upstream patch which fixes the build with lld
  - alsa-project/alsa-lib@2a736a0
- The previous lld-related patches are not needed anymore

Signed-off-by: Michal Rostecki <vadorovsky@protonmail.com>
Changes:
- Version bump to 1.2.11
- The previous hdspmixer patch is not needed anymore

Signed-off-by: Michal Rostecki <vadorovsky@protonmail.com>
Changes:
- Version bump to 1.2.11
- The previous 1.2.10-related patchset is not needed anymore

Signed-off-by: Michal Rostecki <vadorovsky@protonmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-12 16:53 UTC
Newest commit scanned: 9094767
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/28f6c5d3f6/output.html

@vadorovsky
Copy link
Contributor Author

It's green, thanks!

@thesamesam
Copy link
Member

Thank you! I'm sorry I was slow to review too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants