app-misc/recoll: Version bump to 1.37.4

[ppurka]

Bug: https://bugs.gentoo.org/923124
Signed-off-by: Punarbasu Purkayastha ppurka@gmail.com

Latest version includes a fix for a compilation error.

[gentoo-bot]

Pull Request assignment

Submitter: @ppurka
Areas affected: ebuilds
Packages affected: app-misc/recoll

app-misc/recoll: @ppurka, @gentoo/proxy-maint

Linked bugs

Bugs linked: 923124

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2024-02-07 21:22 UTC
Newest commit scanned: 6d1f7d8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d50399b82e/output.html

[thesamesam]

Please don't commit as stable, per https://devmanual.gentoo.org/keywording/index.html#keywording-on-upgrades. pkgcheck scan --commits should warn on this too.

Also, from pkgdiff-mg -b old new, I see:

+  AC_ARG_ENABLE(webpreview,
+    AS_HELP_STRING([--disable-webpreview], [Implement the GUI preview windows with webkit or
+    webengine instead of qtextbrowser. This will usually produce a better display, but will
+    sometimes fail to display anything because of JS issues.]),
+    enableWebpreview=$enableval, enableWebpreview="yes")
+if test "$enableWebpreview" != "yes" ; then
+   AC_DEFINE([PREVIEW_FORCETEXTBROWSER], [], [Use QTextBrowser to implement the preview windows])
+fi
+

Does the ebuild need updating for that?

[ppurka]

I had noticed the following in the release notes and decided not to enable this USE flag.

Changes in Recoll 1.37.0

    Display previews using the main HTML engine (webkit or webengine) instead of a QTextBrowser. This improves highlighting search terms while walking them with the Prev/Next buttons.

Let me have another look - I can possibly enable it internally if user disables the webengine USE flag. I will fix the keyword.

[thesamesam]

Thanks! Please @ me when you've checked it so we can get this in.

[ppurka]

@thesamesam Updated the ebuild with the two changes requested. Thanks for reviewing the commits!

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2024-03-02 20:49 UTC
Newest commit scanned: 6e1df2b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ae9fdada33/output.html