dev-games/t4k-common: Fix building with gcc 14 #35241
Conversation
Pull Request assignmentSubmitter: @listout dev-games/t4k-common: @gentoo/games Linked bugsBugs linked: 923789 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
| if(xmlStrcasecmp(node->name, "menu") == 0) { | ||
| i = 0; | ||
| - for(child = node->children; child; child = child->next) { | ||
| + for(child = (struct _xmlAttr *)node->children; child; child = child->next) { |
There was a problem hiding this comment.
I'm not sure this is right. Please remember that casting is the last resort because it silences the conversion warning/error. A cast will always "work" at compile-time even if it's wrong.
It seems wrong to have to cast a _xmlNode to a _xmlAttr. node->children seems like it should definitely be a node, and if we look at https://gnome.pages.gitlab.gnome.org/libxml2/devhelp/libxml2-tree.html#xmlNode, the attributes may be contained in ->properties? But then child is supposedly an xmlAttr to begin with. It might need to be split into another variable to avoid treating it as two types. Go check wehere child is first declared.
There was a problem hiding this comment.
From a glance, I think you may want to just use a new variable name like xmlNode childNode; childNode; childNode = childNode->next, then fix the contents of the for loop.
Pull request CI reportReport generated at: 2024-02-09 06:53 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Closes: https://bugs.gentoo.org/923789 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
listout
force-pushed
the
t4k-common-gcc14-fix
branch
from
f823d91
to
b2a228a
Compare
|
@thesamesam do you think it a bit more proper now? Thanks for review BTW |
Pull request CI reportReport generated at: 2024-02-14 15:44 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@listout I noticed the upstream PR you commented on still has the old patch in it. Please update that. |
|
@thesamesam Done, thanks! |
Closes: https://bugs.gentoo.org/923789