www-servers/tomcat: add {9.0.87-r2,10.1.20}, unbundling bnd #35320
Conversation
Pull Request assignmentSubmitter: @vaukai dev-java/bnd: @gentoo/proxy-maint (new package) Linked bugsBugs linked: 203080 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
Pull request CI reportReport generated at: 2024-02-14 10:58 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-02-15 08:28 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
from the error it seems to miss bnd ant task. i just emerged bndlib and didn't find anything that would resemble the bnd ant task. but i haven't used ant for quite a long time. so, to fix the issue, we need bnd ant task available for ant. |
even with so i guess i have to add more stuff to the bnd ebuild but i dislike bundling |
Pull request CI reportReport generated at: 2024-02-16 14:18 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
i think we don't need to bundle all that stuff that we already have in the tree and can put it on classpath. and if there is something that we don't have in the tree, better than bundling is to package it separately. anyway, the main issue is that the build system cannot find the bnd task. looking at the build.xml, i can see that the task is defined in a properties file: https://github.com/apache/tomcat/blob/9.0.x/build.xml#L3932 and that file reveals that the task is defined by aQute.bnd.ant.BndTask: i guess this is what we miss and need. |
that's it, almost. adding the missing resource file takes me a step further. i'll split the new
here is the last part of the log: |
Pull request CI reportReport generated at: 2024-02-17 15:58 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
is it on |
sorry for long delay. |
Pull request CI reportReport generated at: 2024-03-01 12:22 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
i think putting |
adding that line blocks would i need to rename there are some packages in from the description in |
Pull request CI reportReport generated at: 2024-03-02 09:47 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
well, looking at the code you can use
yes, i agree that it would be better to use use |
that's what i've tried before and it didn't even let me
this can be done separately after cleaning old |
Pull request CI reportReport generated at: 2024-03-02 19:38 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
tried |
Pull request CI reportReport generated at: 2024-03-03 11:12 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-03-18 17:43 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-03-19 14:22 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-03-19 20:12 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-03-20 08:13 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-03-22 08:13 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@fordfrog moving to |
Pull request CI reportReport generated at: 2024-03-26 10:10 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
vaukai
changed the title
Pull request CI reportReport generated at: 2024-04-01 08:41 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-04-02 12:15 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| <link href="../websocketapi"/> | ||
| <link href="../jaspicapi"/> | ||
| - <link href="https://docs.oracle.com/en/java/javase/11/docs/api/"/> | ||
| - <link href="https://jakarta.ee/specifications/platform/10/apidocs/"/> |
There was a problem hiding this comment.
this is not copy related so might be a separate patch or the patch should be renamed
There was a problem hiding this comment.
this is not copy related so might be a separate patch or the patch should be renamed
done, separated.
dev-java/eclipse-ecj/files/ecj-4.27
Outdated
| JAVAC="@GENTOO_PORTAGE_EPREFIX@/usr/bin/ecj-4.27" | ||
| PACKAGE="=dev-java/eclipse-ecj-4.27*" | ||
| SUPPORTED_TARGET="1.1 1.2 1.3 1.4 1.5 1.6 1.7 1.8 9 10 11 12 13 14 15 16 17 18 19" | ||
| SUPPORTED_SOURCE="1.3 1.4 1.5 1.6 1.7 1.8 9 10 11 12 13 14 15 16 17 18 19" |
There was a problem hiding this comment.
so i checked that and this seems to be fine:
https://github.com/eclipse-jdt/eclipse.jdt.core/blob/R4_27_maintenance/org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java#L223-L243
|
i merged the two ecj commits. as for tomcat, we should polish the patches i think. |
- adds here document "build.properties" for configuration - reduces the -build.xml.patch by using build.properties - adds tomcat-9.0.87-gentoo-bnd.patch re-adding the unbundled parts - removes the src_unpack() section - removes -Dbnd.jar from EANT_EXTRA_ARGS - updates eclipse-ecj 4.15 -> 4.20 - drops REWRITE_CLASSPATH, allows to drop -9.0.37-fix-build-rewrite.patch - drops EANT_NEED_TOOLS - removes the src_configure() section - simplifies MY_P - shortens verify-sig string by using MY_P - unkeyword 9.0.87-r2 for ~x86 Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
Pull request CI reportReport generated at: 2024-04-03 09:46 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-04-03 10:25 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
could not resist to try, but it fails:
should we follow upstream and have
bndbundlebndlib?