Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-tcltk/tktreectrl: EAPI8 bump, use https #35391

Closed
wants to merge 1 commit into from

Conversation

mm1ke
Copy link
Contributor

@mm1ke mm1ke commented Feb 17, 2024

Another EAPI8 bump.

I've also looked into bug #828839.
From what i've found is that X cannot really be disabled with this package (and to be honest, i think it doesn't make sense either). Trying to disable X results in following configure warning:

checking for X... disabled
checking for X11 header files... checking for X11 libraries... checking for XCreateWindow in -lXwindow... no
could not find any!  Using -lX11

This means -lX11 is being used regardless of the flag. And since dev-lang/tk depends anyway on libX11 it never fails.

I've looked into other package and i've decided to go with simply enable X per default. It similar to what for example dev-tcltk/blk does.
However i couldn't reproduce the QA warning from the bug in any case. This might be because this happend on musl on the bug. It would be nice if someone with a musl system could test it.

The other bug #906870 however i could reproduce and i've simply fixed it with:

QA_CONFIG_IMPL_DECL_SKIP=(
	stat64 # used to test for Large File Support
)

Signed-off-by: Michael Mair-Keimberger mmk@levelnine.at

Bug: https://bugs.gentoo.org/828839
Closes: https://bugs.gentoo.org/906870

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mm1ke
Areas affected: ebuilds
Packages affected: dev-tcltk/tktreectrl

dev-tcltk/tktreectrl: @gentoo/sci

Linked bugs

Bugs linked: 906870, 828839


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 17, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-17 15:28 UTC
Newest commit scanned: 58f8005
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8953447de1/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-04 22:18 UTC
Newest commit scanned: 969b3a1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5b6c12fce0/output.html

Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>

Bug: https://bugs.gentoo.org/828839
Closes: https://bugs.gentoo.org/906870
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-10 20:04 UTC
Newest commit scanned: 6f69869
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4a1c219940/output.html

@AndrewAmmerlaan AndrewAmmerlaan self-assigned this Apr 11, 2024
@AndrewAmmerlaan
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants