Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-java/jimfs: new package, add 1.3.0 | dev-java/junit: add 5.10.2 #35482

Closed
wants to merge 3 commits into from

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Feb 22, 2024

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 22, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-22 00:33 UTC
Newest commit scanned: 8e43c11
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cc570dde06/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-22 00:48 UTC
Newest commit scanned: 16c5066
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/36f66eae4a/output.html

@vaukai vaukai marked this pull request as draft February 22, 2024 09:40
@vaukai vaukai marked this pull request as ready for review February 22, 2024 11:16
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-22 11:28 UTC
Newest commit scanned: 8e4802b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b4c4a8e031/output.html

@vaukai vaukai changed the title dev-java/junit: junit-4.13.2-java21.patch dev-java/junit: add 4.13.2_p20230501 to allow jdk:21 Feb 22, 2024
@vaukai vaukai changed the title dev-java/junit: add 4.13.2_p20230501 to allow jdk:21 dev-java/junit: add 4.13.2_p20230501 to allow jdk:21[please reassign] Apr 6, 2024
@gentoo-bot gentoo-bot changed the title dev-java/junit: add 4.13.2_p20230501 to allow jdk:21[please reassign] dev-java/junit: add 4.13.2_p20230501 to allow jdk:21 Apr 6, 2024
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 6, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-06 19:40 UTC
Newest commit scanned: 82c4625
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e2d056684f/output.html

@vaukai vaukai changed the title dev-java/junit: add 4.13.2_p20230501 to allow jdk:21 dev-java/junit: add 4.13.2_p20230501 to allow jdk:21| dev-java/junit: add 5.10.2 Apr 7, 2024
@vaukai vaukai force-pushed the junit4 branch 2 times, most recently from ebc283f to bd80724 Compare April 8, 2024 17:08
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-08 17:57 UTC
Newest commit scanned: bd80724
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/934e1a99f1/output.html

@vaukai
Copy link
Contributor Author

vaukai commented Apr 10, 2024

@fordfrog
this one might please be the next of my PRs to get merged. the junit5 update was overdue since ages, the junit4 update to snapshot allows removing the jdk restriction at the cost of one failing test which i had to patch out. the junit3 commit is just a minor style update including EAPI 7 -> 8.

@fordfrog
Copy link
Contributor

junit-5 fails the tests for me:

>>> Test phase: dev-java/junit-5.10.2
removed 'example/IgnoredTestsDemo.java'
removed 'example/DocumentationTestSuite.java'
removed 'example/SuiteDemo.java'
removed 'example/JUnit4Tests.java'
removed 'example/JUnitPlatformClassDemo.java'
removed 'example/JUnitPlatformSuiteDemo.java'
removed 'example/testkit/EngineTestKitAllEventsDemo.java'
removed 'example/testkit/EngineTestKitFailedMethodDemo.java'
removed 'example/testkit/EngineTestKitSkippedMethodDemo.java'
removed 'example/testkit/EngineTestKitStatisticsDemo.java'
removed directory 'example/testkit/'
removed 'org/junit/api/tools/AbstractApiReportWriter.java'
removed 'org/junit/api/tools/ApiReport.java'
removed 'org/junit/api/tools/ApiReportGenerator.java'
removed 'org/junit/api/tools/ApiReportWriter.java'
removed 'org/junit/api/tools/AsciidocApiReportWriter.java'
removed 'org/junit/api/tools/HtmlApiReportWriter.java'
removed 'org/junit/api/tools/MarkdownApiReportWriter.java'
removed directory 'org/junit/api/tools/'
removed 'example/HamcrestAssertionsDemo.java'
removed 'example/session/HttpTests.java'
javac -source 1.8 -target 1.8 -d /var/tmp/portage/dev-java/junit-5.10.2/temp/junit5_src_test/classes -encoding UTF-8 -classpath /usr/share/apiguardian-api/lib/apiguardian-api.jar:/usr/share/opentest4j/lib/opentest4j.jar:/usr/share/open-test-reporting-events/lib/open-test-reporting-events.jar:/usr/share/picocli/lib/picocli.jar:/usr/share/univocity-parsers/lib/univocity-parsers.jar:/usr/share/open-test-reporting-schema/lib/open-test-reporting-schema.jar::/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-commons/junit-platform-commons.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-engine/junit-platform-engine.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-launcher/junit-platform-launcher.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-reporting/junit-platform-reporting.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-console/junit-platform-console.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-api/junit-jupiter-api.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-engine/junit-jupiter-engine.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-params/junit-jupiter-params.jar @/var/tmp/portage/dev-java/junit-5.10.2/temp/junit5_src_test/sources.lst
warning: [options] bootstrap class path not set in conjunction with -source 8
warning: [options] source value 8 is obsolete and will be removed in a future release
warning: [options] target value 8 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
4 warnings
javac -source 1.8 -target 1.8 -d /var/tmp/portage/dev-java/junit-5.10.2/temp/junit5_src_test/test-classes -encoding UTF-8 -classpath /var/tmp/portage/dev-java/junit-5.10.2/temp/junit5_src_test/classes:documentation/src/test/resources:/usr/share/apiguardian-api/lib/apiguardian-api.jar:/usr/share/opentest4j/lib/opentest4j.jar:/usr/share/open-test-reporting-events/lib/open-test-reporting-events.jar:/usr/share/picocli/lib/picocli.jar:/usr/share/univocity-parsers/lib/univocity-parsers.jar:/usr/share/open-test-reporting-schema/lib/open-test-reporting-schema.jar::/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-commons/junit-platform-commons.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-engine/junit-platform-engine.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-launcher/junit-platform-launcher.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-reporting/junit-platform-reporting.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-console/junit-platform-console.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-api/junit-jupiter-api.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-engine/junit-jupiter-engine.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-params/junit-jupiter-params.jar @/var/tmp/portage/dev-java/junit-5.10.2/temp/junit5_src_test/test-sources.lst
warning: [options] bootstrap class path not set in conjunction with -source 8
warning: [options] source value 8 is obsolete and will be removed in a future release
warning: [options] target value 8 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
documentation/src/test/java/example/TempDirectoryDemo.java:28: error: package com.google.common.jimfs does not exist
import com.google.common.jimfs.Configuration;
                              ^
documentation/src/test/java/example/TempDirectoryDemo.java:29: error: package com.google.common.jimfs does not exist
import com.google.common.jimfs.Jimfs;
                              ^
documentation/src/test/java/example/TempDirectoryDemo.java:135: error: cannot find symbol
			private final FileSystem fileSystem = Jimfs.newFileSystem(Configuration.unix());
			                                      ^
  symbol:   variable Jimfs
  location: class JimfsTempDirFactory
documentation/src/test/java/example/TempDirectoryDemo.java:135: error: cannot find symbol
			private final FileSystem fileSystem = Jimfs.newFileSystem(Configuration.unix());
			                                                          ^
  symbol:   variable Configuration
  location: class JimfsTempDirFactory
4 errors
4 warnings

Copy link
Contributor

@fordfrog fordfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was postponing this one as i wanted to have a look why it fails. i didn't dig much deep but what i found is that this test has over the ages recurring issues so i'm leaving it as it is.

@fordfrog
Copy link
Contributor

what's approved is merged now. i also reordered variables on some ebuilds to remove to pkgcheck warnings.

@vaukai vaukai force-pushed the junit4 branch 2 times, most recently from 04ec297 to 6874975 Compare April 12, 2024 08:33
@vaukai vaukai marked this pull request as ready for review April 12, 2024 08:38
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-12 08:45 UTC
Newest commit scanned: 04ec297
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a3daedf7a6/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-12 09:10 UTC
Newest commit scanned: 6874975
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/127efea5ff/output.html

Copy link
Contributor

@fordfrog fordfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem with the tests imo is that the package misses META-INF/services file in the jar. i suggest you first build the package using maven, then check the content of the file and replicate that within the ebuild. that should fix the tests.

@vaukai
Copy link
Contributor Author

vaukai commented Apr 13, 2024

problem with the tests imo is that the package misses META-INF/services file in the jar. i suggest you first build the package using maven, then check the content of the file and replicate that within the ebuild. that should fix the tests.

done.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-13 08:34 UTC
Newest commit scanned: c0125cd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a2135e224a/output.html

Closes: https://bugs.gentoo.org/929903
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
Bug: https://bugs.gentoo.org/921398
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@vaukai vaukai changed the title dev-java/jimfs: new package, add 1.3.0 | dev-java/junit: add 5.10.2 dev-java/jimfs: new package, add 1.3.0 | dev-java/junit: add 5.10.2 [please reassign] Apr 13, 2024
@gentoo-bot gentoo-bot changed the title dev-java/jimfs: new package, add 1.3.0 | dev-java/junit: add 5.10.2 [please reassign] dev-java/jimfs: new package, add 1.3.0 | dev-java/junit: add 5.10.2 Apr 13, 2024
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: dev-java/antlr-tool, dev-java/icu4j, dev-java/jimfs, dev-java/junit

dev-java/antlr-tool: @gentoo/java
dev-java/icu4j: @gentoo/java
dev-java/jimfs: @gentoo/proxy-maint (new package)
dev-java/junit: @gentoo/java

Linked bugs

Bugs linked: 921398, 929903


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 13, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-13 13:44 UTC
Newest commit scanned: e658e37
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ee55eacc00/output.html

@vaukai vaukai closed this Apr 14, 2024
@vaukai vaukai deleted the junit4 branch April 14, 2024 07:39
@vaukai vaukai restored the junit4 branch April 14, 2024 07:46
@fordfrog
Copy link
Contributor

it's done now, i just merged junit.

@vaukai
Copy link
Contributor Author

vaukai commented Apr 14, 2024

it's done now, i just merged junit.

sorry for those many late changes ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package.
Projects
None yet
4 participants