meson.eclass /: EMESON_BUILDTYPE & deduplicate some debug logic #35593

mjsir911 · 2024-03-02T00:39:02Z

Not sure if this PR is an overstep or if the commits are grouped together but this will help to potentially avoid issues like https://bugs.gentoo.org/925949

Also, EMESON_BUILDTYPE hasn't been used anywhere previously?

15:47 < mjsir911> question about EMESON_BUILDTYPE: is anything actually using it? Is this intended to be used in ebuilds or specified by users calling emerge? I'm a bit confused
15:48 <@sam_> I had no idea it existed until you mentioned it
15:48 <@sam_> or i forgot about it
15:48 <@sam_> i think the former though ;)

Of note is that commit d066871 introduces a change in the build process for some packages
eg glib that didn't previously set -Db_ndebug when use debug

gentoo-bot · 2024-03-02T00:40:02Z

Pull Request assignment

Submitter: @mjsir911
Areas affected: ebuilds, eclasses
Packages affected: dev-libs/efl, dev-libs/glib, dev-util/intel_clc, media-libs/mesa, media-libs/mesa-amber...

dev-libs/efl: @juippis
dev-libs/glib: @gentoo/gnome
dev-util/intel_clc: @gentoo/x11
media-libs/mesa: @gentoo/x11
media-libs/mesa-amber: @gentoo/x11
media-libs/rubberband: @gentoo/proaudio
sys-auth/elogind: @a17r
x11-base/xorg-server: @gentoo/x11
x11-wm/mutter: @gentoo/gnome

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2024-03-02T00:53:04Z

Pull request CI report

Report generated at: 2024-03-02 00:53 UTC
Newest commit scanned: a064f2f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ce470f0664/output.html

gentoo-repo-qa-bot · 2024-03-02T01:07:57Z

Pull request CI report

Report generated at: 2024-03-02 01:07 UTC
Newest commit scanned: aba9921
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/faf011a22a/output.html

thesamesam · 2024-03-02T23:08:02Z

cc @eli-schwartz

eli-schwartz · 2024-03-03T01:45:24Z

dev-libs/glib/glib-2.78.4-r1.ebuild

+	use debug && EMESON_BUILDTYPE=debug
+
 	local emesonargs=(
-		-Dbuildtype=$(usex debug debug plain)


This first commit makes sense. People really should have used it for consistency, indeed.

I can drop the two other commits and/or make a new PR and/or would it be possible to just merge in this (and the glib_debug) commit?

eli-schwartz · 2024-03-03T01:49:57Z

eclass/meson.eclass

@@ -368,7 +368,8 @@ setup_meson_src_configure() {


 	if in_iuse debug; then
-		use debug && EMESON_BUILDTYPE=debug
+		MESONARGS+=( -Db_ndebug=$(usex debug false true) )


So this is setting -DNDEBUG now, for all ebuilds that have a USE="-debug".

How is this handled for other build systems?

... it's very painful: https://bugs.gentoo.org/884791. We used to pass -DNDEBUG in cmake-utils.eclass and cmake.eclass for a time, then we stopped, and every so often, we get broken software as a result..

eli-schwartz · 2024-03-03T01:55:08Z

eclass/meson.eclass

+	if in_iuse debug; then
+		use debug && EMESON_BUILDTYPE=debug
+	fi


Are there meson.eclass using ebuilds that define IUSE=debug but didn't set the buildtype?

Note in general this feels a bit weird. The purpose of IUSE=debug is:

Enable extra debug codepaths, like asserts and extra output. If you want to get meaningful backtraces see https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Backtraces

but the debug buildtype in meson simply adds things like -g, which is specifically intended to not be the same thing.

This is why ebuilds declare it locally if they need it, typically because the meson.build files themselves check the value of the "debug" buildtype to enable additional "debug codepaths, like asserts and extra output".

The -Dn_debug flag specifically enables/disables asserts:
https://mesonbuild.com/Builtin-options.html#base-options

To answer the question though, yes there are packages that don't set the buildtype that define IUSE=debug:

app-emulation/dxvk

app-emulation/vkd3d-proton

dev-cpp/glibmm

dev-db/postgresql

games-emulation/dosbox-staging

gnome-base/gnome-control-center

gnome-base/gnome-desktop

gnome-base/gnome-settings-daemon

gnome-extra/nautilus-sendto

gui-libs/vte

media-gfx/geeqie

media-libs/gegl

media-libs/harfbuzz

media-libs/opus

media-libs/rlottie

net-irc/hexchat

net-libs/gnome-online-accounts

net-libs/libsrtp

net-misc/eventd

net-misc/networkmanager

net-p2p/transmission-remote-gtk

sys-apps/dbus

sys-apps/kmscon

sys-apps/openrc

sys-block/open-iscsi

www-client/elinks

x11-libs/cairo

x11-libs/pango

x11-libs/vte

The -Dn_debug flag specifically enables/disables asserts:
https://mesonbuild.com/Builtin-options.html#base-options

Yes, that would be why this review comment is NOT about the ndebug option, but about the buildtype option.

(It is b_ndebug, not n_debug, however.)

dev-libs/glib/glib-2.78.4-r1.ebuild

gentoo-repo-qa-bot · 2024-03-03T04:04:12Z

Pull request CI report

Report generated at: 2024-03-03 04:04 UTC
Newest commit scanned: 78312c6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b4fe1b5724/output.html

mjsir911 · 2024-03-14T06:14:53Z

@eli-schwartz would it make sense to re-push the PR with only the first two commits?

eli-schwartz · 2024-03-14T06:24:48Z

I think so, yes. They are uncontroversial, at least.

For the first commit in particular I think it makes sense to provide a more detailed commit message explaining why the change was made.

glib has a special flag signalling a debug build, without this, G_ENABLE_DEBUG is only set iff --debug=true AND --optimization={0,g} (which, admittedly, -Dbuildtype=debug *does* do. It's just better to be explicit about these things) Signed-off-by: Marco Sirabella <marco@sirabella.org>

Signed-off-by: Marco Sirabella <marco@sirabella.org>

gentoo-repo-qa-bot · 2024-03-14T15:28:00Z

Pull request CI report

Report generated at: 2024-03-14 15:28 UTC
Newest commit scanned: dcd9d1a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/acd3fa1ffe/output.html

eli-schwartz

Sorry, forgot to actually respond.

eli-schwartz · 2024-04-03T04:54:39Z

For batching reasons I opened a mega-PR above ^^. It cherry-picks these commits directly.

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Mar 2, 2024

mjsir911 force-pushed the use_emeson_buildtype branch from a064f2f to d066871 Compare March 2, 2024 00:40

mjsir911 marked this pull request as draft March 2, 2024 00:44

mjsir911 force-pushed the use_emeson_buildtype branch from d066871 to aba9921 Compare March 2, 2024 00:50

mjsir911 marked this pull request as ready for review March 2, 2024 00:50

eli-schwartz reviewed Mar 3, 2024

View reviewed changes

mjsir911 force-pushed the use_emeson_buildtype branch from aba9921 to 78312c6 Compare March 3, 2024 03:47

mjsir911 force-pushed the use_emeson_buildtype branch from 78312c6 to 725323f Compare March 14, 2024 14:57

mjsir911 added 2 commits March 14, 2024 07:57

*/*: -Dbuildtype -> EMESON_BUILDTYPE

dcd9d1a

Signed-off-by: Marco Sirabella <marco@sirabella.org>

mjsir911 force-pushed the use_emeson_buildtype branch from 725323f to dcd9d1a Compare March 14, 2024 14:58

mjsir911 requested a review from eli-schwartz March 14, 2024 15:43

eli-schwartz approved these changes Apr 3, 2024

View reviewed changes

eli-schwartz mentioned this pull request Apr 3, 2024

meson.eclass: updates #36071

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

meson.eclass /: EMESON_BUILDTYPE & deduplicate some debug logic #35593

meson.eclass /: EMESON_BUILDTYPE & deduplicate some debug logic #35593

mjsir911 commented Mar 2, 2024 •

edited

gentoo-bot commented Mar 2, 2024

gentoo-repo-qa-bot commented Mar 2, 2024

gentoo-repo-qa-bot commented Mar 2, 2024

thesamesam commented Mar 2, 2024

eli-schwartz Mar 3, 2024

mjsir911 Mar 3, 2024

eli-schwartz Mar 3, 2024

thesamesam Mar 3, 2024 •

edited

eli-schwartz Mar 3, 2024

mjsir911 Mar 3, 2024

mjsir911 Mar 3, 2024

eli-schwartz Mar 3, 2024

gentoo-repo-qa-bot commented Mar 3, 2024

mjsir911 commented Mar 14, 2024

eli-schwartz commented Mar 14, 2024

gentoo-repo-qa-bot commented Mar 14, 2024

eli-schwartz left a comment

eli-schwartz commented Apr 3, 2024

meson.eclass */*: EMESON_BUILDTYPE & deduplicate some debug logic #35593

Are you sure you want to change the base?

meson.eclass */*: EMESON_BUILDTYPE & deduplicate some debug logic #35593

Conversation

mjsir911 commented Mar 2, 2024 • edited

gentoo-bot commented Mar 2, 2024

Pull Request assignment

Linked bugs

Missing GCO sign-off

gentoo-repo-qa-bot commented Mar 2, 2024

Pull request CI report

gentoo-repo-qa-bot commented Mar 2, 2024

Pull request CI report

thesamesam commented Mar 2, 2024

eli-schwartz Mar 3, 2024

Choose a reason for hiding this comment

mjsir911 Mar 3, 2024

Choose a reason for hiding this comment

eli-schwartz Mar 3, 2024

Choose a reason for hiding this comment

thesamesam Mar 3, 2024 • edited

Choose a reason for hiding this comment

eli-schwartz Mar 3, 2024

Choose a reason for hiding this comment

mjsir911 Mar 3, 2024

Choose a reason for hiding this comment

mjsir911 Mar 3, 2024

Choose a reason for hiding this comment

eli-schwartz Mar 3, 2024

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Mar 3, 2024

Pull request CI report

mjsir911 commented Mar 14, 2024

eli-schwartz commented Mar 14, 2024

gentoo-repo-qa-bot commented Mar 14, 2024

Pull request CI report

eli-schwartz left a comment

Choose a reason for hiding this comment

eli-schwartz commented Apr 3, 2024

meson.eclass /: EMESON_BUILDTYPE & deduplicate some debug logic #35593

meson.eclass /: EMESON_BUILDTYPE & deduplicate some debug logic #35593

mjsir911 commented Mar 2, 2024 •

edited

thesamesam Mar 3, 2024 •

edited