Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-portage/emlop: add 0.7.0 #35625

Closed

Conversation

vincentdephily
Copy link
Contributor

@Flowdalic

Thank you.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vincentdephily
Areas affected: ebuilds
Packages affected: app-portage/emlop

app-portage/emlop: moltonel[at]gmail.com, @gentoo/proxy-maint

Linked bugs

Bugs linked: 922533


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 5, 2024
EAPI=8

CRATES="
adler-1.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pkgcheck scan and address any warnings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

# Copyright 2023-2024 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2

# Auto-Generated by cargo-ebuild 0.5.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recommend using pycargoebuild at this point (as it won't generate output causing warnings, for a start).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like pycargoebuild doesn't generate

# rust does not use *FLAGS from make.conf, silence portage warning                                                                                                                                                                          
QA_FLAGS_IGNORED="usr/bin/${PN}"

TBH I don't fully understand what it does, so I left it in for now. Should I remove it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating the right value for QA_FLAGS_IGNORED is non-trival for tools. And it is still required to silence the QA warning, so we want to keep it.

Bug: https://bugs.gentoo.org/922533
Signed-off-by: Vincent de Phily <moltonel@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-05 11:03 UTC
Newest commit scanned: 347fd59
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1115ddccdd/output.html

@gentoo-bot gentoo-bot closed this in 56b6320 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants