New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-portage/emlop: add 0.7.0 #35625
app-portage/emlop: add 0.7.0 #35625
Conversation
Pull Request assignmentSubmitter: @vincentdephily app-portage/emlop: Linked bugsBugs linked: 922533 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
app-portage/emlop/emlop-0.7.0.ebuild
Outdated
EAPI=8 | ||
|
||
CRATES=" | ||
adler-1.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run pkgcheck scan
and address any warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
app-portage/emlop/emlop-0.7.0.ebuild
Outdated
# Copyright 2023-2024 Gentoo Authors | ||
# Distributed under the terms of the GNU General Public License v2 | ||
|
||
# Auto-Generated by cargo-ebuild 0.5.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recommend using pycargoebuild at this point (as it won't generate output causing warnings, for a start).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like pycargoebuild doesn't generate
# rust does not use *FLAGS from make.conf, silence portage warning
QA_FLAGS_IGNORED="usr/bin/${PN}"
TBH I don't fully understand what it does, so I left it in for now. Should I remove it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating the right value for QA_FLAGS_IGNORED is non-trival for tools. And it is still required to silence the QA warning, so we want to keep it.
Bug: https://bugs.gentoo.org/922533 Signed-off-by: Vincent de Phily <moltonel@gmail.com>
79271d8
to
347fd59
Compare
Pull request CI reportReport generated at: 2024-03-05 11:03 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
emlop.toml
file installed in docs@Flowdalic
Thank you.