Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup cmake.eclass EAPI-7 stragglers #35651

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Cleanup cmake.eclass EAPI-7 stragglers #35651

wants to merge 4 commits into from
+0 −274

Conversation

a17r
Copy link
Member

@a17r a17r commented Mar 7, 2024

In the year 2024 we do not bump new ebuilds as EAPI-7. Please.

@a17r a17r added the no assignee limit Ignore assignee limit, and ping as many maintainers as it takes. label Mar 7, 2024
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 7, 2024
@beatussum
Copy link
Contributor

b7ac755 is duplicate with #35603.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-07 11:18 UTC
Newest commit scanned: b0ec16d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/75036c959e/output.html

@a17r a17r changed the title Cleanup cmake.eclass EAPI-7 stragglers Cleanup cmake.eclass EAPI-7 stragglers [please reassign] Mar 7, 2024
@gentoo-bot gentoo-bot changed the title Cleanup cmake.eclass EAPI-7 stragglers [please reassign] Cleanup cmake.eclass EAPI-7 stragglers Mar 7, 2024
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 7, 2024
@a17r a17r changed the title Cleanup cmake.eclass EAPI-7 stragglers Cleanup cmake.eclass EAPI-7 stragglers [please reassign] Mar 7, 2024
@gentoo-bot gentoo-bot changed the title Cleanup cmake.eclass EAPI-7 stragglers [please reassign] Cleanup cmake.eclass EAPI-7 stragglers Mar 7, 2024
@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 7, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-07 13:52 UTC
Newest commit scanned: 499e339
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a14d718291/output.html

@a17r a17r changed the title Cleanup cmake.eclass EAPI-7 stragglers Cleanup cmake.eclass EAPI-7 stragglers [please reassign] Mar 7, 2024
@gentoo-bot gentoo-bot changed the title Cleanup cmake.eclass EAPI-7 stragglers [please reassign] Cleanup cmake.eclass EAPI-7 stragglers Mar 7, 2024
@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 7, 2024
@a17r a17r requested a review from ZeroChaos- March 7, 2024 14:06
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-24 21:21 UTC
Newest commit scanned: c714b27
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/738a6c1618/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-25 12:00 UTC
Newest commit scanned: b295a75
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b930a803f0/output.html

@a17r a17r changed the title Cleanup cmake.eclass EAPI-7 stragglers Cleanup cmake.eclass EAPI-7 stragglers [please reassign] Mar 26, 2024
@gentoo-bot gentoo-bot changed the title Cleanup cmake.eclass EAPI-7 stragglers [please reassign] Cleanup cmake.eclass EAPI-7 stragglers Mar 26, 2024
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @a17r
Areas affected: ebuilds
Packages affected: dev-db/pgrouting, dev-db/timescaledb, dev-libs/leatherman, gnustep-base/libobjc2, media-libs/glm...

dev-db/pgrouting: @gentoo/postgresql
dev-db/timescaledb: @gentoo/postgresql
dev-libs/leatherman: @prometheanfire
gnustep-base/libobjc2: @gentoo/gnustep
media-libs/glm: @atupone
net-analyzer/icinga2: @prometheanfire
net-libs/rabbitmq-c: prathamIN[at]proton.me, @gentoo/proxy-maint
net-misc/apt-cacher-ng: @ajakk
net-print/brlaser: @cyrevolt, @gentoo/proxy-maint, @gentoo/printing
sci-chemistry/gromacs: @alexxy, @gentoo/sci-chemistry
sci-libs/ignition-fuel-tools: aballier

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

Bugs linked: 926345

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 26, 2024
@a17r a17r requested a review from alexxy March 26, 2024 11:28
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-26 12:30 UTC
Newest commit scanned: a72cb26
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/538a6789b9/output.html

voyageur
voyageur suggested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@voyageur voyageur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current libobjc2 2.2 looks good and has up-to-date EAPI, just note on patches cleanup

gnustep-base/libobjc2/libobjc2-2.1.ebuild Outdated Show resolved Hide resolved
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-27 13:35 UTC
Newest commit scanned: bf5a284
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e81cc0ff19/output.html

@a17r a17r requested review from atupone and removed request for prometheanfire March 27, 2024 17:01
atupone
atupone approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@atupone atupone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'm OK to remove the old glm version, but I have not done because is stable and I have not tested all the reverse deps.
Actually if one of these fails during build is just one liner fix:
add
#define GLM_ENABLE_EXPERIMENTAL
at the begin of each failing source.

@a17r
Copy link
Member Author

a17r commented Mar 27, 2024 •
edited

Personally I'm OK to remove the old glm version, but I have not done because is stable and I have not tested all the reverse deps. Actually if one of these fails during build is just one liner fix: add #define GLM_ENABLE_EXPERIMENTAL at the begin of each failing source.

The only reported failure with that was recently fixed and is currently pending stabilisation, I'm not going to drop the old version before that is done: https://bugs.gentoo.org/927790

@a17r
dev-db/timescaledb: drop 2.14.0
1b4f22f 
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
@a17r
media-libs/glm: drop 0.9.9.8-r1
71d5487 
Closes: https://bugs.gentoo.org/926345
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
@a17r
dev-db/pgrouting: drop 3.2.1, 3.5.1
0b3cad6 
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
@a17r
sci-libs/ignition-math: drop 6.14.0
100f329 
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-28 23:25 UTC
Newest commit scanned: 100f329
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ae10900673/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voyageur voyageur voyageur requested changes

@chewi chewi chewi approved these changes

@ZeroChaos- ZeroChaos- ZeroChaos- approved these changes

@atupone atupone atupone approved these changes

@Chiitoo Chiitoo Chiitoo approved these changes

Assignees
No one assigned
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually. no assignee limit Ignore assignee limit, and ping as many maintainers as it takes.
Projects
None yet
Milestone
No milestone
10 participants
@a17r @beatussum @gentoo-repo-qa-bot @mattst88 @gentoo-bot @chewi @voyageur @ZeroChaos- @atupone @Chiitoo