-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*/tree-sitter-*: support new upstream bindings #35750
Conversation
Pull Request assignmentSubmitter: @arthurzam dev-libs/tree-sitter: @thrifty-txt, @sarnex, @msva, @MatthewGentoo Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2024-03-14 14:58 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK (besides the existing comments). Thanks for handling it.
Pull request CI reportReport generated at: 2024-03-18 07:08 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
a013014
to
c123bae
Compare
Pull request CI reportReport generated at: 2024-03-18 21:13 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-03-18 21:42 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
The build system for tree-sitters now generates a much better Makefile we can use to build the parser and grammar into a good C library. This also matches the build procedure used by upstream, making our reports easier for them to debug (we hit this issue in an old bug report on memory leak with tree-sitter-bash). Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
New tree-sitter cli generated bindings and code around grammars and parsers now support bulding a python wheel which supply much better API and library for consumers in python bindings. Currently I've added only python as a binding languages, even though rust, swift, and go are also available. We should add them when we see a request for them. Python will be needed for pkgcheck. When we opt in into python bindings, we call the matching distutils phase functions when `use python` is true. Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Pull request CI reportReport generated at: 2024-03-22 18:03 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
So what we have in this package of patches for now:
${S}
variable.This is somewhat backward incompatible, but I think this is worth it (I'll fix all ebuilds which define themselves
S=
)pquery --raw --attr alldepends --attr required_use --attr iuse -v --max --repo ~/dev/gentoo =dev-libs/tree-sitter-bash-0.21.0
To see new python bindings in work, install
dev-python/tree-sitter-0.21.0
anddev-libs/tree-sitter-bash-0.21.0
, and the run:Things to do:
S=
ebuild *.ebuild install
on all tree-sitter grammar ebuilds, and verify they all buildfor f in $(grep -r . -e 'inherit.*tree-sitter-grammar' -l); do ebuild $f clean install clean || echo "failed $f" >> /tmp/fail.log; done