media-sound/pasystray: Add libappindicator and X as optional dependen… #35858
Conversation
Pull Request assignmentSubmitter: @0xfea5 media-sound/pasystray: @lmiphay, @gentoo/sound, @gentoo/proxy-maint Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2024-03-21 18:13 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| @@ -37,6 +38,8 @@ src_prepare() { | |||
|
|
|||
| src_configure() { | |||
| econf \ | |||
| $(use_enable X x11) \ | |||
| $(use_enable appindicator appindicator) \ | |||
There was a problem hiding this comment.
what were the defaults here? and does that X use flag affect x11-libs/libX11 or not?
|
As far as I tested, *building without X support* does affect the binary but
it still *links with X libraries*. Thus I decided to keep the Xlibs
dependency at all times. Now that I see it, it will probably be too
confusing to pull Xlibs independently of the X flag so perhaps it should
not be an option.
Ideally building without X support should not link with Xlibs at all but
that requires a fix from the project's side.
…On Fri, Mar 22, 2024, 10:48 Miroslav Šulc ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In media-sound/pasystray/pasystray-0.8.1.ebuild
<#35858 (comment)>:
> @@ -37,6 +38,8 @@ src_prepare() {
src_configure() {
econf \
+ $(use_enable X x11) \
+ $(use_enable appindicator appindicator) \
what were the defaults here? and does that X use flag affect
x11-libs/libX11 or not?
—
Reply to this email directly, view it on GitHub
<#35858 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJDQMNKGE2R6IP6Q4JXDDEDYZPV5BAVCNFSM6AAAAABFB55XXWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJUGI2TENRTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
pasystray offers the option to build with/without support for X and libappindicator. With this small update, the ebuilds can now reflect these options.