Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-sound/qpwgraph: add 0.6.2, drop 0.6.1 #35884

Closed
wants to merge 1 commit into from

Conversation

AdelKS
Copy link
Contributor

@AdelKS AdelKS commented Mar 23, 2024

No description provided.

Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @AdelKS
Areas affected: ebuilds
Packages affected: media-sound/qpwgraph

media-sound/qpwgraph: @AdelKS, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Mar 23, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-23 17:55 UTC
Newest commit scanned: ff616b5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bf174871ff/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future please split adding and removing to their own individual commits. Also use a tool such as pkgdev to do automatic fixes for you, like updating the copyright line.

@AdelKS
Copy link
Contributor Author

AdelKS commented Apr 26, 2024

In future please split adding and removing to their own individual commits.

Isn't it better in the case of single-ebuild package to have a single commit so the changes on the ebuild can be tracked?

Also use a tool such as pkgdev to do automatic fixes for you, like updating the copyright line.

Thanks I'll look into that

@juippis
Copy link
Member

juippis commented Apr 26, 2024

Isn't it better in the case of single-ebuild package to have a single commit so the changes on the ebuild can be tracked?

No, the changes are trackable already (simplest with an experimental diff.renames copies-harder)

But:
1: it's impossible to review the updated ebuild in GH and spot errors
2: if the new version didn't work for everyone and they'd ask the old version to be restored, we could just git revert commit-deleting-the-old-version. Now with a single commit that would also get rid of the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants