app-cdr/cdrtools: Remove dependency x11-misc/makedepend

[fictitiousexistence]

Remove x11-misc/makedepend as build does not seem to require it.

[gentoo-bot]

Pull Request assignment

Submitter: @fictitiousexistence
Areas affected: ebuilds
Packages affected: app-cdr/cdrtools

app-cdr/cdrtools: @billie80

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2024-03-24 03:10 UTC
Newest commit scanned: 9fa7db6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3902db5aa5/output.html

[billie80]

This dependency was added in 2014 (https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/app-cdr/cdrtools?id=9fc1d2b1d529eab9d76dd084cb7f4ad9e355b767) and was still required in 2021 (https://gitweb.gentoo.org/repo/gentoo.git/commit/app-cdr/cdrtools?id=7138ee0fe68cac7adf083255541cb18b32fbf688) and I don't think anything changed since. It is still called from rules.prg in the source code.
Do you just think it is not used because you say it seems to be not required?

[fictitiousexistence]

@billie80
I removed makedepend from my system and was able to compile it without any difference.
Could not find anything about makedepend in the build output.
No error with "align_test".

        ==> MAKING "all" ON SUBCOMPONENT "SRCROOT/inc/align_test.mk"
        ==> COMPILING "OBJ/12th-gen-intel-r--core-tm--i7-1260p-linux-cc/align_test.o"
        ==> LINKING "OBJ/12th-gen-intel-r--core-tm--i7-1260p-linux-cc/align_test"

No .d file with a 'do not delete' comment.

Is https://gitweb.gentoo.org/repo/gentoo.git/commit/app-cdr/cdrtools?id=7138ee0fe68cac7adf083255541cb18b32fbf688
saying that makedepend is just needed for riscv?

Thanks.

[billie80]

I don't know! If you want to remove it you have to make sure it works under all conditions.
I myself wasn't involved in the addition of this dependency nor in the other commit mentioned. For me the current state is fine given that cdrtools is outdated anyway, the package itself is horror to maintain and burning CD/DVDs lost its importance.
Given all this I wouldn't bother with this small dependency.