Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-astronomy/calcmysky-0.3.1: DEPEND on <media-libs/glm-1 to fix com… #35908

Closed
wants to merge 1 commit into from

Conversation

jaakristioja
Copy link
Contributor

…pilation

Closes: https://bugs.gentoo.org/923036

…pilation

Closes: https://bugs.gentoo.org/923036
Signed-off-by: Jaak Ristioja <jaak@ristioja.ee>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @jaakristioja
Areas affected: ebuilds
Packages affected: sci-astronomy/calcmysky

sci-astronomy/calcmysky: @DarthGandalf, @gentoo/proxy-maint, @gentoo/sci-astronomy

Linked bugs

Bugs linked: 923036


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 25, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-25 10:40 UTC
Newest commit scanned: 5cf5b95
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2930eaf1a3/output.html

@a17r
Copy link
Member

a17r commented Mar 25, 2024

Without a revbump, this will help no one having this installed already. 0.3.2 is now in ::gentoo and will be stabilised.

@jaakristioja
Copy link
Contributor Author

Without a revbump, this will help no one having this installed already.

Yes it would. Whoever built calcmysky against <glm-1 and then upgraded to glm to 1.0 will face the issue reported in bug #923036 when rebuilding calcmysky. When we just change the dependency it will cause glm to be downgraded before rebuilding calcmysky.

However, come to think of it, perhaps the dependency in DEPEND should be left as-is and a dependency on glm which includes a version specifier should be added to BDEPEND instead?

@a17r
Copy link
Member

a17r commented Mar 27, 2024

To rephrase: RDEPEND changes require revbumps, otherwise the change is not effective in vdb. I don't think it should be touched really - calcmysky was already fixed in 0.3.2 which is being stabilised right now (only ppc64 is missing): https://bugs.gentoo.org/927790

@a17r a17r closed this Mar 27, 2024
@jaakristioja jaakristioja deleted the bgo-923036 branch April 30, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants