distutils-r1.eclass: next batch of updates #35913
Conversation
Pull Request assignmentSubmitter: @mgorny dev-python/boto: @gentoo/python Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
eclass/distutils-r1.eclass
Outdated
| # remove installed licenses | ||
| find "${root}$(python_get_sitedir)" -depth \ | ||
| \( -path '*.dist-info/COPYING*' \ | ||
| -o -path '*.dist-info/LICENSE*' \ | ||
| -o -path '*.dist-info/license_files/*' \ | ||
| -o -path '*.dist-info/license_files' \ | ||
| -o -path '*.dist-info/licenses/*' \ | ||
| -o -path '*.dist-info/licenses' \ | ||
| # remove installed licenses and other junk | ||
| find "${root}$(python_get_sitedir)" -depth -path '*.dist-info/*' \ | ||
| \! \( -name 'METADATA' \ | ||
| -o -name 'WHEEL' \ | ||
| -o -name 'entry_points.txt' \ | ||
| -o -name 'pbr.json' \ | ||
| -o -name 'top_level.txt' \ |
There was a problem hiding this comment.
As I said in IRC, I don't believe this is robust handling. A backend can choose to install files which are not documented in the spec, but which have tool-specific meaning, and require those files.
Your response was to cherry-pick the single example I gave and allow that file as well.
Pull request CI reportReport generated at: 2024-03-25 19:41 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| @@ -33,18 +33,9 @@ RDEPEND=" | |||
|
|
|||
| BDEPEND=" | |||
There was a problem hiding this comment.
If I already see it, so might as well ask.
In @mgorny style rules, do you prefer multiline or just BDEPEND="${RDEPEND}" when direct assign?
There was a problem hiding this comment.
I prefer multi-line, since you don't have to change it if you need to add more deps.
| @@ -628,11 +628,11 @@ distutils_enable_tests() { | |||
| ;; | |||
| unittest) | |||
| # unittest-or-fail is needed in py<3.12 | |||
| test_deps+=" | |||
| $(python_gen_cond_dep ' | |||
| local test_pkgs="$(python_gen_cond_dep ' | |||
There was a problem hiding this comment.
I don't think you need " quoting here (since direct $() assign into var). But maybe safer to include them in case someone modifies in future...
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Refactor `distutils_enable_tests pytest` to move `test_pkgs` logic straight into pytest block, as it is not used by any other variant anymore. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Closes: https://bugs.gentoo.org/926964 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Closes: https://bugs.gentoo.org/927818 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Explicitly error out if epytest is run without an appropriate async plugin, and the test suite contains async tests. Currently, these tests are skipped with a warning but that is usually a mistake, and one can easily miss it when pytest-asyncio or a similar plugin is installed on the test system. However, a missing dependency can result in the tests being skipped afterwards on the tinderbox. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Pull request CI reportReport generated at: 2024-03-29 16:53 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
pdm-pep517withpdm-backendfinally.dist-info