Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x11-apps/xdm: Fix -Wincompatible-pointer-types warning from GCC 14 #35916

Closed
wants to merge 1 commit into from
Closed

x11-apps/xdm: Fix -Wincompatible-pointer-types warning from GCC 14 #35916

wants to merge 1 commit into from

Conversation

listout
Copy link
Contributor

@listout listout commented Mar 25, 2024 •
edited

Fixes build when building against libXaw 1.0.16 since
xorg/lib/libxaw@d0fcbd97 changed the definition of XawListChange
in <X11/Xaw/List.h> from _Xconst char * to String *, where
String is defined as const if _CONST_X_STRING is defined.

Closes: https://bugs.gentoo.org/927712
Signed-off-by: Brahmajit Das brahmajit.xyz@gmail.com

@listout listout changed the title x11-apps/xdm: Fix -Wincompatible-pointer-types warning from gcc x11-apps/xdm: Fix -Wincompatible-pointer-types warning from GCC 14 Mar 25, 2024
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: x11-apps/xdm

x11-apps/xdm: @gentoo/x11

Linked bugs

Bugs linked: 927712

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 25, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-25 19:05 UTC
Newest commit scanned: 72b6544
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e017d032de/output.html

@alanc
Copy link

alanc commented Mar 25, 2024

The xdm-1.1.15-gcc14.patch patch here claims to be my upstream patch from https://gitlab.freedesktop.org/xorg/app/xdm/-/merge_requests/18/diffs but it's actually the inverse of my patch, undoing my change and restoring the previous code.

The actual root cause here is a change in libXaw 1.0.16 that was made earlier this month, as discussed in https://gitlab.freedesktop.org/xorg/app/xdm/-/issues/16.

@listout
Copy link
Contributor Author

listout commented Mar 25, 2024

@alanc That's right, as I said in the Gitlab issue, I somehow completely missed it, I'll fix it.

@listout listout marked this pull request as draft March 25, 2024 20:50
@listout
x11-apps/xdm: Fix -Wincompatible-pointer-types warning from GCC 14
a16450d 
Fixes build when building against libXaw 1.0.16 since
xorg/lib/libxaw@d0fcbd97 changed the definition of XawListChange
in <X11/Xaw/List.h> from _Xconst char * to String *, where
String is defined as const if _CONST_X_STRING is defined.

Closes: https://bugs.gentoo.org/927712
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
@listout listout marked this pull request as ready for review April 3, 2024 04:58
@listout
Copy link
Contributor Author

listout commented Apr 3, 2024

@alanc should be good now, I backported your patch from master. Thank you!

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-03 05:31 UTC
Newest commit scanned: a16450d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8afebf6feb/output.html

@mattst88
Copy link
Contributor

This is all fixed in xdm-1.1.16, right?

@mattst88 mattst88 closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@listout @gentoo-bot @gentoo-repo-qa-bot @alanc @mattst88