New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] media-gfx/openscad: latest including manifold and Qt 6 #35936
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Chris Mayo <aklhfex@gmail.com>
Signed-off-by: Chris Mayo <aklhfex@gmail.com>
Signed-off-by: Chris Mayo <aklhfex@gmail.com>
Pull Request assignmentSubmitter: @cjmayo dev-cpp/cccl: @gentoo/proxy-maint (new package) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial brief comments, not looked through it all.
SLOT="0" | ||
KEYWORDS="~amd64" | ||
|
||
RESTRICT="mirror" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove those before anything leaves draft.
SLOT="0" | ||
KEYWORDS="~amd64" | ||
|
||
RESTRICT="mirror" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
REQUIRED_USE="python? ( ${PYTHON_REQUIRED_USE} )" | ||
|
||
# tests not included in PyPI archive (but nanobind and quickhull are) | ||
RESTRICT="test mirror" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also an openscad-9999.ebuild, IMHO it would be good to keep that in sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The live ebuild could be different if it pulls in submodules, needing fewer of the new ebuilds. That live ebuild may also be the better one to update first while the use of manifold is still experimental (looks like there will be another manifold release before then as well).
But it won't be me getting it working - although I'm happy to help review. I'll post on the bug as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this comes from openscad/openscad#4929
Can we include the git metadata in the patch file for tracking purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to wait until Qt 6 CMake support was merged upstream but there was a rush of activity on the bug trying to understand the thrust headers.
Seems like we are close to getting 4929 merged now. I'll update the snapshot here when that is done.
Signed-off-by: Chris Mayo <aklhfex@gmail.com>
Signed-off-by: Chris Mayo <aklhfex@gmail.com>
Pull request CI reportReport generated at: 2024-04-17 18:51 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
A draft PR to try and help https://bugs.gentoo.org/908591
Updated ebuilds:
media-gfx/openscad
New ebuilds (with RESTRICT=mirror):
dev-cpp/cccl (for those without dev-util/nvidia-cuda-toolkit)
dev-util/sanitizers-cmake
sci-mathematics/clipper2
sci-mathematics/manifold
Happy to split off / amend if anyone with commit rights is interested. Else this is what works for me. I may post updates (with a rebase) when I have them.