Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] media-gfx/openscad: latest including manifold and Qt 6 #35936

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Mar 26, 2024

A draft PR to try and help https://bugs.gentoo.org/908591

Updated ebuilds:

media-gfx/openscad

New ebuilds (with RESTRICT=mirror):

dev-cpp/cccl (for those without dev-util/nvidia-cuda-toolkit)
dev-util/sanitizers-cmake
sci-mathematics/clipper2
sci-mathematics/manifold

Happy to split off / amend if anyone with commit rights is interested. Else this is what works for me. I may post updates (with a rebase) when I have them.

Signed-off-by: Chris Mayo <aklhfex@gmail.com>
Signed-off-by: Chris Mayo <aklhfex@gmail.com>
Signed-off-by: Chris Mayo <aklhfex@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @cjmayo
Areas affected: ebuilds
Packages affected: dev-cpp/cccl, dev-util/sanitizers-cmake, media-gfx/openscad, sci-mathematics/clipper2, sci-mathematics/manifold...

dev-cpp/cccl: @gentoo/proxy-maint (new package)
dev-util/sanitizers-cmake: @gentoo/proxy-maint (new package)
media-gfx/openscad: @negril, @gentoo/proxy-maint
sci-mathematics/clipper2: @gentoo/proxy-maint (new package)
sci-mathematics/manifold: @gentoo/proxy-maint (new package)
x11-libs/qscintilla: @gentoo/qt

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 26, 2024
@cjmayo cjmayo changed the title [WIPmedia-gfx/openscad: latest including manifold and Qt 6 [WIP] media-gfx/openscad: latest including manifold and Qt 6 Mar 26, 2024
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial brief comments, not looked through it all.

SLOT="0"
KEYWORDS="~amd64"

RESTRICT="mirror"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove those before anything leaves draft.

media-gfx/openscad/openscad-20240325.ebuild Outdated Show resolved Hide resolved
SLOT="0"
KEYWORDS="~amd64"

RESTRICT="mirror"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

REQUIRED_USE="python? ( ${PYTHON_REQUIRED_USE} )"

# tests not included in PyPI archive (but nanobind and quickhull are)
RESTRICT="test mirror"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

sci-mathematics/manifold/manifold-2.4.5.ebuild Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also an openscad-9999.ebuild, IMHO it would be good to keep that in sync.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The live ebuild could be different if it pulls in submodules, needing fewer of the new ebuilds. That live ebuild may also be the better one to update first while the use of manifold is still experimental (looks like there will be another manifold release before then as well).

But it won't be me getting it working - although I'm happy to help review. I'll post on the bug as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this comes from openscad/openscad#4929

Can we include the git metadata in the patch file for tracking purposes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to wait until Qt 6 CMake support was merged upstream but there was a rush of activity on the bug trying to understand the thrust headers.

Seems like we are close to getting 4929 merged now. I'll update the snapshot here when that is done.

Signed-off-by: Chris Mayo <aklhfex@gmail.com>
Signed-off-by: Chris Mayo <aklhfex@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. no bug found No Bug/Closes found in the commits.
Projects
None yet
5 participants