Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/elasticsearch: add 8.13.0 + friends and new deps #35962

Closed
wants to merge 6 commits into from

Conversation

parona-source
Copy link
Contributor

  • Dropped keywords due to new dependencies.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @parona-source
Areas affected: ebuilds
Packages affected: dev-python/elastic-transport, dev-python/elasticsearch, dev-python/opentelemetry-api, dev-python/opentelemetry-sdk, dev-python/opentelemetry-semantic-conventions...

dev-python/elastic-transport: @parona-source, @gentoo/proxy-maint
dev-python/elasticsearch: @parona-source, @gentoo/proxy-maint
dev-python/opentelemetry-api: @gentoo/proxy-maint (new package)
dev-python/opentelemetry-sdk: @gentoo/proxy-maint (new package)
dev-python/opentelemetry-semantic-conventions: @gentoo/proxy-maint (new package)
dev-python/respx: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Mar 28, 2024
@parona-source parona-source force-pushed the elasticsearch branch 3 times, most recently from df4629b to 727bba1 Compare March 28, 2024 12:36
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-28 13:00 UTC
Newest commit scanned: 727bba1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/727ee31758/output.html

@parona-source
Copy link
Contributor Author

In regard to

OPENTELEMETRY_PUBLIC="1.23.0"
OPENTELEMETRY_PRIVATE="0.44_beta0"

opentelemetry-python has two versions for its packages a public and a private https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.23.0

I found it reasonable to include both in all ebuilds so that during an ebuild bump someone couldn't forget about bumping the private version.

Currently the only use of the private version is in relation opentelemetry-semantic-conventions which could alternatively use the public version, but this would require patching metadata.

https://github.com/open-telemetry/opentelemetry-python/blob/v1.23.0/opentelemetry-sdk/pyproject.toml#L29

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-28 14:05 UTC
Newest commit scanned: 45002d3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cdf01a5fc1/output.html

@mgorny
Copy link
Member

mgorny commented Mar 28, 2024

Jeez, what a mess. How about we just use the "public" version as PV, and let the Python package version disagree? It will be a bit confusing, I guess, but still better than having to manually update the version on every single bump.

Signed-off-by: Alfred Wingate <parona@protonmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-28 19:22 UTC
Newest commit scanned: b0c3a7e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5b29259a78/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-28 19:45 UTC
Newest commit scanned: 85e80c0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/170becc6b5/output.html

Signed-off-by: Alfred Wingate <parona@protonmail.com>
Signed-off-by: Alfred Wingate <parona@protonmail.com>
Signed-off-by: Alfred Wingate <parona@protonmail.com>
Signed-off-by: Alfred Wingate <parona@protonmail.com>
Signed-off-by: Alfred Wingate <parona@protonmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-29 15:07 UTC
Newest commit scanned: b48418a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9ed8277aa8/output.html

@parona-source
Copy link
Contributor Author

@mgorny
Copy link
Member

mgorny commented Mar 29, 2024

Thanks!

@mgorny mgorny self-assigned this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants