Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-apps/attr: Add missing libgen.h include for basename(3) #36010

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sys-apps/attr: Add missing libgen.h include for basename(3) #36010

wants to merge 1 commit into from
+29 −0

Conversation

lanodan
Copy link
Contributor

@lanodan lanodan commented Mar 31, 2024

Fixes compilation issue with musl and modern C99 compilers.

Closes: https://bugs.gentoo.org/926294

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @lanodan
Areas affected: ebuilds
Packages affected: sys-apps/attr

sys-apps/attr: @gentoo/base-system

Linked bugs

Bugs linked: 926294

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 31, 2024
@lanodan
sys-apps/attr: Add missing libgen.h include for basename(3)
f157411 
Fixes compilation issue with musl and modern C99 compilers.

Closes: https://bugs.gentoo.org/926294
Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-31 04:30 UTC
Newest commit scanned: ee1aa87
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/22b01cf7df/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-31 04:52 UTC
Newest commit scanned: f157411
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/393a349490/output.html

akhuettel
akhuettel suggested changes Apr 28, 2024
View reviewed changes
Copy link
Member

@akhuettel akhuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means the code does not use GNU basename but POSIX basename, which modifies its argument. For sure compiles, but does it run or does it crash?
=> Not a valid solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhuettel akhuettel akhuettel requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@lanodan @gentoo-bot @gentoo-repo-qa-bot @akhuettel