sci-libs/mpfi-1.5.4: Port to C99 by fixing incompatible pointers #36024
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a difference between a pointer to struct and pointer to 1-element array embedding said struct, from modern compiler point of view. Disambigue that difference in code by taking the address of zeroth element instead of whole array. Upstream has an updated tarball mpfi-1.5.4 with file missing tests folder, in current tarball, to successfully enable `make check`, ebuild test and FEATURES=test. Beyond the missing file, newer tarball includes also major changes, autotools and other code differences I do not feel qualified to judge. Upstream can't or doesn't semver their code. This is why the package is not revision-bumped, still on tarball from 2019 instead of tarball from 2022 and doesn't have tests enabled. Closes: https://bugs.gentoo.org/921351 Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
Pull Request assignmentSubmitter: @NHOrus sci-libs/mpfi: @gentoo/sci-mathematics Linked bugsBugs linked: 921351 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2024-03-31 19:25 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a difference between a pointer to struct and pointer to 1-element array embedding said struct, from modern compiler point of view. Disambigue that difference in code by taking the address of zeroth element instead of whole array.
Upstream has an updated tarball mpfi-1.5.4 with file missing tests folder, in current tarball, to successfully enable
make check, ebuild test and FEATURES=test. Beyond the missing file, newer tarball includes also major changes, autotools and other code differences I do not feel qualified to judge. Upstream can't or doesn't semver their code.This is why the package is not revision-bumped, still on tarball from 2019 instead of tarball from 2022 and doesn't have tests enabled.
Closes: https://bugs.gentoo.org/921351