Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-im/slack: make wayland conditional rdepend #36075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

furrycatherder
Copy link

No description provided.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @furrycatherder
Areas affected: ebuilds
Packages affected: net-im/slack

net-im/slack: @SpiderX, @dlan17, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Apr 3, 2024
Signed-off-by: Sean Haugh <sean@lfo.team>
@furrycatherder
Copy link
Author

Added a signoff. (Sorry, first-time contributer.)

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-03 14:10 UTC
Newest commit scanned: 11ede87
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f8fa60d9fc/output.html

@dlan17
Copy link
Contributor

dlan17 commented Apr 6, 2024

hi, slack is released in binary version, so you couldn't get ride of wayland .. have you actually tested it with wayland free environment?

$ ldd /opt/slack/slack |grep -in wayland
libwayland-server.so.0 => /usr/lib64/libwayland-server.so.0 (0x00007f51d2620000)
$ qfile /usr/lib64/libwayland-server.so.0
dev-libs/wayland: /usr/lib64/libwayland-server.so.0

@furrycatherder
Copy link
Author

furrycatherder commented Apr 9, 2024

hi, slack is released in binary version, so you couldn't get ride of wayland .. have you actually tested it with wayland free environment?

$ ldd /opt/slack/slack |grep -in wayland libwayland-server.so.0 => /usr/lib64/libwayland-server.so.0 (0x00007f51d2620000) $ qfile /usr/lib64/libwayland-server.so.0 dev-libs/wayland: /usr/lib64/libwayland-server.so.0

Hi yes, I've been running slack with this change for a while now.

$ ldd /opt/slack/slack | grep -in wayland
$ qfile /usr/lib64/libwayland-server.so.0

My profile is default/linux/amd64/23.0/desktop/systemd if that helps at all.

@dlan17
Copy link
Contributor

dlan17 commented Apr 12, 2024

/usr/lib64/libwayland-server.so.0

em.. then dev-libs/wayland is probably an indirect dependency which pulled by some packages,
in this case, let me see if we can just drop the dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
4 participants