Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-libs/libcap-ng: link using libcap-ng.la #36101

Closed
wants to merge 2 commits into from
Closed

sys-libs/libcap-ng: link using libcap-ng.la #36101

wants to merge 2 commits into from

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Apr 4, 2024

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @orbea
Areas affected: ebuilds
Packages affected: sys-libs/libcap-ng

sys-libs/libcap-ng: @gentoo/base-system

Linked bugs

Bugs linked: 928450

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 4, 2024
floppym
floppym reviewed Apr 4, 2024
View reviewed changes
sys-libs/libcap-ng/libcap-ng-0.8.4-r1.ebuild Outdated
# bug #668722
eautomake
sed -i "s@cat /usr@cat ${EPREFIX}/usr@" bindings/python*/Makefile.am || die
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop this sed because it no longer does anything. See stevegrubb/libcap-ng@a22d36a.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we should pass this to configure instead:

--with-capability_header="${ESYSROOT}"/usr/include/linux/capability.h

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a second commit that adds --with-capability_header and removes the sed, I think this is what you meant?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's perfect. Thanks.

@orbea
sys-libs/libcap-ng: use --with-capability_header
335771d 
The sed no longer does anything so use the new upstream configure
argument instead.

Upstream-Commit: stevegrubb/libcap-ng@a22d36a
Signed-off-by: orbea <orbea@riseup.net>
@gentoo-bot gentoo-bot closed this in a7a715d Apr 4, 2024
@orbea orbea deleted the libcap-ng-slibtool branch April 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floppym floppym floppym left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
3 participants
@orbea @gentoo-bot @floppym