app-text/zathura-9999: fix ebuild

[BouncyMaster]

1. Update disable-seccomp-tests patch
2. Bump girara version
3. Make sqlite a hard dependency

[gentoo-bot]

Pull Request assignment

Submitter: @BouncyMaster
Areas affected: ebuilds
Packages affected: app-text/zathura

app-text/zathura: @turret-dev, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2024-04-06 12:30 UTC
Newest commit scanned: 2320fcd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/21284729ce/output.html

[BouncyMaster]

I find it weird that currently we rely on a 3rd party for building the manpages. I think it's better to just build them locally, we only need dev-python/sphinx for that. Will update this PR.

[turret-dev]

I find it weird that currently we rely on a 3rd party for building the manpages. I think it's better to just build them locally, we only need dev-python/sphinx for that. Will update this PR.

"If upstream does not ship prebuilt manpages and building them requires additional dependencies, the maintainer should build them and ship along with the package." (https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0305)
As I learned in my first PR to this specific package and so I will push forward down, in the words of Sam James: Always worth checking git history to see why something was done a certain way.

Regardless, thank you for your contribution. I'll review in a bit since I need to ask around on IRC a couple of things first.

[BouncyMaster]

"If upstream does not ship prebuilt manpages and building them requires additional dependencies, the maintainer should build them and ship along with the package." (https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0305) As I learned in my first PR to this specific package and so I will push forward down, in the words of Sam James: Always worth checking git history to see why something was done a certain way.

Just FYI, for 9999 the manpage wasn't installed at all previously (was the intention to use the stable manpage instead?)

Anyway, I'll just revert my last change for now, keeping the other fixes.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2024-04-06 17:45 UTC
Newest commit scanned: 2887a22
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ba0c308ddb/output.html

[Flowdalic]

I find it weird that currently we rely on a 3rd party for building the manpages. I think it's better to just build them locally, we only need dev-python/sphinx for that. Will update this PR.

"If upstream does not ship prebuilt manpages and building them requires additional dependencies, the maintainer should build them and ship along with the package." (https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0305)

I think it is perfectly fine if live ebuilds build the manpages themselves.

[turret-dev]

I think it is perfectly fine if live ebuilds build the manpages themselves.

yeah, the only downside is either tons of conditionals or having 9999 need to be updated separately, both of which make maintaining the package harder.

zathura is a very simple package imo with the package maintainer pushing changes and then immediately tagging a release for those changes
only reason zathura is behind rn is due to pwmt having issues with their infra making the only distribution tarball available from debian
can i have your advice on that? im assuming it'd just be fine but i'd like the opinion of a developer before proceeding

[Flowdalic]

only reason zathura is behind rn is due to pwmt having issues with their infra making the only distribution tarball available from debian

I noticed that they did not put 0.5.5 on https://pwmt.org/projects/zathura/download/ (you may want to ping upstream about that), but the tarball from https://git.pwmt.org/pwmt/zathura/-/archive/0.5.5/zathura-0.5.5.tar.bz2 from https://git.pwmt.org/pwmt/zathura/-/tags is not an option?

That said, do not feel obligated to package every release of an upstream with very frequent releases. Some upstreams have multiple releases per month. Packaging every release involves often a high cost and leaves less resources for other package maintenance tasks like stabilization and bug fixing.