Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline mirror://sourceforge #36198

Closed
wants to merge 4 commits into from
Closed

Conversation

antecrescent
Copy link
Contributor

@antecrescent antecrescent commented Apr 10, 2024

Sourceforge is using download bouncer these days, so tpm entry lists only 1 server. Inline it.

Closes #13105 as discussed there.
Also mass-bumps copyright of touched files (due to pkgdev commit).

Generated in a git-cleaned repo with:

for f in $(grep -rlE "mirror://sourceforge[^.jp]" --exclude-dir=metadata --exclude-dir=.git)
do
    sed -i "s,mirror://sourceforge,https://downloads.sourceforge.net," $f
done

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @antecrescent
Areas affected: ebuilds, eclasses, profiles
Packages affected: app-accessibility/epos, app-accessibility/freetts, app-accessibility/sphinx2, app-accessibility/yasr, app-admin/chroot_safe...

@gentoo/github: Too many disjoint maintainers, disabling auto-assignment.

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits. labels Apr 10, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-10 19:19 UTC
Newest commit scanned: 0e5e665
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/aefb1072cc/output.html

@thesamesam thesamesam requested a review from mgorny April 11, 2024 16:14
@mgorny
Copy link
Member

mgorny commented Apr 11, 2024

Let's split eclass changes into separate commits.

bump copyright to 2024

Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
bump copyright to 2024

Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
bump copyright of touched ebuilds to 2024

Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
@antecrescent
Copy link
Contributor Author

I asked the maintainer of ruby-ng-gnome2 for comments on the proposed change on Wednesday. If I don't hear from them today, I plan to the introduce the eclass changes on gentoo-dev tomorrow.

Thanks for the review!

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-12 11:11 UTC
Newest commit scanned: 49284c8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/08e6195a5b/output.html

@mgorny
Copy link
Member

mgorny commented Apr 12, 2024

You don't really need to wait before sending patches to the ml.

Since this thing is bound to get outdated all the time, here's what I propose: let's get eclass changes sent to the ml ASAP, wait a bit, and then I'll push them, redo your sed and push the results, credited to you. I'll probably split it a bit, though, to let pkgcheck scan --commits --net double-check everything.

@antecrescent
Copy link
Contributor Author

Sounds good!

@antecrescent antecrescent marked this pull request as ready for review April 12, 2024 13:22
@floppym
Copy link
Contributor

floppym commented Apr 12, 2024

Just for the heck of it, here's a more efficient incantation.

git grep -l "mirror://sourceforge/" | xargs sed -i "s,mirror://sourceforge/,https://downloads.sourceforge.net/,"

@antecrescent
Copy link
Contributor Author

antecrescent commented Apr 30, 2024

What's the current status of this PR? I'd be happy to help fix miscellaneous issues that pop up with pkgcheck scan --commits --net, for example. I'm not sure about the scope of issues to fix, though.
Stuff I find worth fixing right away:

In the meantime, I'll start fixing issues in my inline_sf_pkgcheck branch.

@mgorny
Copy link
Member

mgorny commented Apr 30, 2024

Oh, sorry about it. I'm going to try doing it now. I suppose the eclass changes cooked long enough on the ml.

@mgorny
Copy link
Member

mgorny commented Apr 30, 2024

That said, lots of these packages don't use canonical sourceforge URIs but instead rely on redirects but that's a separate issue to tackle.

gentoo-bot pushed a commit to gentoo/guru that referenced this pull request Apr 30, 2024
See gentoo/gentoo#36198 for the sed invocation.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits.
Projects
None yet
5 participants