Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-libs/glibc: export CPP similarily to CC and CXX #36200

Closed
wants to merge 1 commit into from
Closed

sys-libs/glibc: export CPP similarily to CC and CXX #36200

wants to merge 1 commit into from

Conversation

parona-source
Copy link
Contributor

  • This is copies the approach that CC and CXX use, so that the correct abi is used. Otherwise an abi_x86_32 configure test could automagically enable CET which isn't available on abi_x86_32.

Bug: https://bugs.gentoo.org/927652

@parona-source
sys-libs/glibc: export CPP similarily to CC and CXX
ce3fd93 
* This is copies the approach that CC and CXX use, so that the correct
  abi is used. Otherwise an abi_x86_32 configure test could
  automagically enable CET which isn't available on abi_x86_32.

Bug: https://bugs.gentoo.org/927652
Signed-off-by: Alfred Wingate <parona@protonmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @parona-source
Areas affected: ebuilds
Packages affected: sys-libs/glibc

sys-libs/glibc: @gentoo/toolchain

Linked bugs

Bugs linked: 927652

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 10, 2024
@thesamesam
Copy link
Member

Why not Closes:?

@parona-source
Copy link
Contributor Author

parona-source commented Apr 10, 2024 •
edited

Why not Closes:?

Well I'm only touching one version so the potential stable keyword llvm profile user would still be affected.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-11 00:04 UTC
Newest commit scanned: ce3fd93
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1ade5144ea/output.html

@thesamesam
Copy link
Member

Why not Closes:?

Well I'm only touching one version so the potential stable keyword llvm profile user would still be affected.

You could backport it fine, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@parona-source @gentoo-bot @thesamesam @gentoo-repo-qa-bot