Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-debug/sysdig: build fixes for musl #36237

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

dev-debug/sysdig: build fixes for musl #36237

wants to merge 3 commits into from
+40 −4

Conversation

hhoffstaette
Copy link
Contributor

@hhoffstaette hhoffstaette commented Apr 13, 2024 •
edited

No revbump since the fixes are musl-only and do not affect glibc systems.
This also needs https://bugs.gentoo.org/929907 to suceed on musl.
Also compile-tested on musl-1.2.5.

@hhoffstaette
dev-debug/sysdig: add missing libelf dependency
a67de68 
Noticed while building in a clean chroot.

Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
@hhoffstaette
dev-debug/sysdig: add a missed <cstdint> include on musl
4d1c584 
Bug: https://bugs.gentoo.org/929227
Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @hhoffstaette
Areas affected: ebuilds
Packages affected: dev-debug/sysdig

dev-debug/sysdig: @hhoffstaette, @gentoo/proxy-maint

Linked bugs

Bugs linked: 929227

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 13, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-13 14:04 UTC
Newest commit scanned: 4d1c584
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2f7f44637a/output.html

@hhoffstaette hhoffstaette marked this pull request as draft April 13, 2024 14:18
@hhoffstaette
dev-debug/sysdig: don't try to link against libanl on musl
58ee606 
libanl is an empty stub library since glibc-2.34 and does not exist
on musl. Since sysdig uses c-ares and therefore does not even need
glibc's async name lookups, we can safely remove it when building
on musl.

Bug: https://bugs.gentoo.org/929227
Bug: https://bugs.gentoo.org/929907
Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
@hhoffstaette hhoffstaette marked this pull request as ready for review April 13, 2024 14:27
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-13 14:49 UTC
Newest commit scanned: 58ee606
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b3258c3a0b/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
3 participants
@hhoffstaette @gentoo-bot @gentoo-repo-qa-bot