Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-emacs/org-mode: added 9.6.26 #36258

Closed
wants to merge 2 commits into from
Closed

Conversation

gentoo-setan
Copy link
Contributor

@gentoo-setan gentoo-setan commented Apr 14, 2024

Based on version 24 and 23. Works for me but I have added the unstable flag for all supported architectures.

This is my first PR to Gentoo.

EDIT:
Signed-off-by: setan gentoo@supporter.addy.io

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @gentoo-setan
Areas affected: ebuilds
Packages affected: app-emacs/org-mode

app-emacs/org-mode: @gentoo/gnu-emacs

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Apr 14, 2024
@gentoo-setan
Copy link
Contributor Author

I have read that I do not need to sign my commits.
Is that true?
How much burden is it for the developers to sign my stuff?

@xgqt
Copy link
Member

xgqt commented Apr 14, 2024

I have read that I do not need to sign my commits. Is that true? How much burden is it for the developers to sign my stuff?

it verifies your authenticity so you have to sign yourself

@ulm
Copy link
Member

ulm commented Apr 14, 2024

There's two different kinds of "sign":

  • Signoff for the Certificate of Origin, see "Missing GCO sign-off" above: This is required.
  • PGP signature of the commit: This is not necessary, developers will (re-)sign your commits before merging them.

@gentoo-setan
Copy link
Contributor Author

What should I do now?
Is the edit enough?

@xgqt
Copy link
Member

xgqt commented Apr 14, 2024

What should I do now? Is the edit enough?

just git commit --amend --signoff

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-14 20:29 UTC
Newest commit scanned: de27485
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a651962efa/output.html

@xgqt
Copy link
Member

xgqt commented Apr 15, 2024

This is my first PR to Gentoo.

EDIT:
Signed-off-by: setan gentoo@supporter.addy.io

You have to add it to the commit and force push to your branch

Signed-off-by: gentoo-setan <gentoo@supporter.addy.io>
@gentoo-setan
Copy link
Contributor Author

is this sufficient?

@xgqt
Copy link
Member

xgqt commented Apr 16, 2024

It looks ok, there shouldn't be a "Merge [...]" commit but this we can remove.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-16 07:04 UTC
Newest commit scanned: db7765e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/aaff32033d/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
5 participants