Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cpp/catch: add multilib support #36325

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dev-cpp/catch: add multilib support #36325

wants to merge 2 commits into from

Conversation

MrDuartePT
Copy link
Contributor

This add multilib support to this two packages.
This help when compiling mangohud using systemd spdlog.

Well @stkw0 give a look and say what you think

Small note: Since mangohud not compiled with clang, if system-spdlog is use, both spdlog and libfmt need to be compile with gcc to not create linker error

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 19, 2024
@MrDuartePT MrDuartePT force-pushed the spdlog-mangohud branch 2 times, most recently from 5ef3e56 to 860d2b2 Compare April 19, 2024 21:18
@MrDuartePT MrDuartePT changed the title dev-libs/spdlog and dev-libs/libfmt: add multilib support [please reassign]dev-libs/spdlog and dev-libs/libfmt: add multilib support Apr 19, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-19 21:19 UTC
Newest commit scanned: 572d03b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bc138c12a2/output.html

@gentoo-bot gentoo-bot changed the title [please reassign]dev-libs/spdlog and dev-libs/libfmt: add multilib support dev-libs/spdlog and dev-libs/libfmt: add multilib support Apr 19, 2024
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @MrDuartePT
Areas affected: ebuilds
Packages affected: dev-cpp/catch, dev-libs/libfmt, dev-libs/spdlog

dev-cpp/catch: @SoapGentoo
dev-libs/libfmt: @candrews
dev-libs/spdlog: @stkw0, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 19, 2024
@candrews
Copy link
Member

I merged the dev-libs/spdlog and dev-libs/libfmt changes.

I'll leave it to the maintainer of dev-cpp/catch to handle that change.

@candrews candrews reopened this Apr 19, 2024
@MrDuartePT
Copy link
Contributor Author

MrDuartePT commented Apr 19, 2024 •
edited

I merged the dev-libs/spdlog and dev-libs/libfmt changes.

I'll leave it to the maintainer of dev-cpp/catch to handle that change.

Well I did some changes thing was not that right

Edit: ok I gonna rebase this

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-19 21:39 UTC
Newest commit scanned: 860d2b2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/dfe7017b7b/output.html

@MrDuartePT
Copy link
Contributor Author

MrDuartePT commented Apr 19, 2024 •
edited

Well rebased @candrews by the way I forget a [${MULTILIB_USEDEP}] on here

@MrDuartePT MrDuartePT changed the title dev-libs/spdlog and dev-libs/libfmt: add multilib support dev-cpp/catch: add multilib support Apr 19, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-19 21:59 UTC
Newest commit scanned: 8a5c42b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c58a548e0e/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-19 22:19 UTC
Newest commit scanned: 0e8dc6f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/79cd6ec937/output.html

@candrews
Copy link
Member

Can you please include an update for the -9999 version in your spdlog commit?

With that, I approve of the spdlog changes. So if/when @SoapGentoo merges the catch changes, he can also merge the spdlog ones.

@MrDuartePT
Copy link
Contributor Author

Can you please include an update for the -9999 version in your spdlog commit?

With that, I approve of the spdlog changes. So if/when @SoapGentoo merges the catch changes, he can also merge the spdlog ones.

Done

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-20 13:19 UTC
Newest commit scanned: 7239e63
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/64e9c4c0b9/output.html

@thesamesam
Copy link
Member

Please make sure to include rationale in commit messages too, not just in the PR description.

@MrDuartePT
Copy link
Contributor Author

Please make sure to include rationale in commit messages too, not just in the PR description.

Sorry about that see it better now

@MrDuartePT MrDuartePT force-pushed the spdlog-mangohud branch 2 times, most recently from ea0fcc1 to 29754ec Compare April 22, 2024 10:59
@MrDuartePT
Copy link
Contributor Author

MrDuartePT commented Apr 22, 2024 •
edited

@candrews it would be better to drop libfmt 10.0.0, 10.1.0, 10.1.1, 10.2.0, 10.2.1 and 10.2.1-r1?
Since the multilib support was a minor change, we can drop the other unstable ebuild that don't have it.

@MrDuartePT
dev-cpp/catch: add multilib support 3.5.2 and up
9f73f00 
* since dev-libs/spdlog-1.12.0-r3 and up requires
* dev-cpp/catch-3.4.0 and up for tests
* multilib support was added to this ebuilds

Signed-off-by: Gonçalo Negrier Duarte <gonegrier.duarte@gmail.com>
@MrDuartePT
dev-libs/spdlog: add missing MULTILIB_USEDEP to catch
12da961 
* this prevents test for failing when multilib is enabled
* also add missing MULTILIB_USEDEP 9999 and 1.13.0-r1
* dev-libs/spdlog support is needed to compile mangohud using system spdlog

Signed-off-by: Gonçalo Negrier Duarte <gonegrier.duarte@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-22 11:19 UTC
Newest commit scanned: 29754ec
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2df00b9707/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-22 11:39 UTC
Newest commit scanned: 12da961
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bb17d4ecce/output.html

@SoapGentoo
Copy link
Member

I'm honestly not super happy to add multilib support for anything not in ::gentoo. How do I know it's still used?

@MrDuartePT
Copy link
Contributor Author

MrDuartePT commented Apr 22, 2024 •
edited

I'm honestly not super happy to add multilib support for anything not in ::gentoo. How do I know it's still used?

Basically this PR started, when a couple months ago @stkw0 (gentoo/guru@8d4c451#r138362394), ask if would be possible to use system spdlog to compile mangohud (after multilib support was added).

I think mangohud should be widely use (at least for user that game on Linux), and I not sure why mangohud never was added to gentoo repos (@AdelKS should have a reason), since heroic and lutris ebuilds exist, and both have support for mangohud.

This multilib support is just for fixing test on spdlog. I don't know if gentoo CI will fail if we left dev-cpp/catch without multilib support (at least on my machine it failed on the 32bits tests)

@AdelKS
Copy link
Contributor

AdelKS commented Apr 22, 2024 •
edited

mangohud never was added to gentoo repos (@AdelKS should have a reason)

I have no reason, I only add ebuilds to ::gentoo and maintain them as proxy when I get asked by @thesamesam 😆
I'd rather keep the packages I maintain in ::guru because gentoo devs are overworked (I want to become one though) and 1) it's faster to get things pushed 2) others can easily help improving/verbumping them (like @MrDuartePT with mangohud)

Thanks for all of this by the way @MrDuartePT !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
7 participants
@MrDuartePT @gentoo-repo-qa-bot @gentoo-bot @candrews @thesamesam @SoapGentoo @AdelKS