Keyword mupdf and dep for ~arm64 #3638
Conversation
Package-Manager: Portage-2.3.3, Repoman-2.3.1
…x-a53 Package-Manager: Portage-2.3.3, Repoman-2.3.1
|
Pull Request assignment Areas affected: ebuilds app-text/mupdf: @xmw |
gentoo-repo-qa-bot
added
the
assigned
|
Are these related? If not, you should submit them separately, otherwise each maintainer can't deal with their own package without it looking weird in the commit history. |
|
Yes. mupdf depends on media-libs/glfw. |
|
Fair enough. I checked glfw and repoman complains about the Wayland stuff. I guess this could be ignored as it is an experimental profile. |
|
Probably. The only changes I made were to the KEYWORDS and copyright date. |
|
dev-libs/wayland and dev-libs/wayland-protocols (behind the wayland USE flag) are not keyworded for arm64. |
|
Wayland on a Raspberry Pi sounds a bit adventurous. Its tested on Xfce4. |
|
The wayland flag could be masked on arm64 pending further testing but I don't mind that much since it's an experimental profile. Just thought I should mention it. |
|
Others may be playing with wayland on arm64. I have no way to tell. It might take them by surprise. Yes its a bit piecemeal but its experimental. leio ran a PR to show all tud ~arm64 arm64 inconsistencies like this. There were 310. This fixes some and creates a few more. |
|
I'll hand over to @xmw to okay this change. I can merge it if he wants. You'll need to rebase though as there's a conflict now. |
|
WFM. |
…ebuild in my favour
|
😞 The QA check for this pull request has found the following issues: New issues caused by PR: |
|
How does adding an ~arm64 keyword cause ppc issues? |
|
You didn't resolve the conflict properly and made ppc/ppc64 unstable rather than stable. You need to rebase in any case as we don't want conflict resolutions in the commit history. Try to follow the steps I told you the other day. |
Package-Manager: Portage-2.3.3, Repoman-2.3.1
Package-Manager: Portage-2.3.3, Repoman-2.3.1
|
commit 9a6260e commit 3ae2c5a |
|
As demonstrated, it's easy enough to make keyword changes ourselves. Just trying to get you more familiar with git! |
|
chewi, I don't understand how I screwed up the ppc keyword. I'll need to learn how to get the history out of git. xmw, Thank you for fixing my mess. |
|
It's hard to say exactly what you did but even though you only wanted to add ~arm64, it looks like in attempting to resolve the conflict, you made it say: KEYWORDS="~arm64 ~ppc ~ppc64"Rather than: KEYWORDS="~arm64 ppc ppc64"You can see this if you click the Files changed tab at the top. |
Works on Raspberry Pi 3 in 64 bit mode.