Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-java/commons-vfs: switch to java-pkg-simple #36404

Closed
wants to merge 1 commit into from
Closed

dev-java/commons-vfs: switch to java-pkg-simple #36404

wants to merge 1 commit into from

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Apr 24, 2024

No description provided.

@vaukai
dev-java/commons-vfs: switch to java-pkg-simple
74d09bd 
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: dev-java/commons-vfs

dev-java/commons-vfs: @gentoo/java

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 24, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-24 14:06 UTC
Newest commit scanned: 74d09bd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1a92f37e1f/output.html

fordfrog
fordfrog reviewed Apr 25, 2024
View reviewed changes
dev-java/commons-vfs/files/commons-vfs-2.0-utf8.patch
throws FileSystemException;

- /** �
+ /**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this patch about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this patch about?

That character is invalid for utf8 and would force us setting java encoding to iso-8859-1

@vaukai vaukai deleted the commons-vfs branch April 25, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fordfrog fordfrog fordfrog left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
4 participants
@vaukai @gentoo-bot @gentoo-repo-qa-bot @fordfrog