New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sci-biology/maq: Fix assignment to incompatible pointer type #36459
Conversation
Pull Request assignmentSubmitter: @listout sci-biology/maq: @gentoo/sci-biology Linked bugsBugs linked: 921137 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
"${FILESDIR}"/${P}-bfr-overfl.patch | ||
"${FILESDIR}"/${P}-gcc-4.7.patch | ||
"${FILESDIR}"/${P}-remove-64bit-flag.patch | ||
"${FILESDIR}"/${P}-gcc14-build-fix.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just bump the other ebuild, dont add a new one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these fixes require a new revision ("revbump") for the reasons described above. Also, developers want to know quickly if the fix is somehow insufficient, and a new revision helps to weed out any problems.
From https://wiki.gentoo.org/wiki/Modern_C_porting#Fixes_.28C99.29
Also since I'm doing a runtime change, thought a revision bump would be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but just add the patch and rename -r3
-> -r4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh ... sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the same for #36460
Closes: https://bugs.gentoo.org/921137 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
Pull request CI reportReport generated at: 2024-04-27 16:44 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-04-27 17:44 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Closes: https://bugs.gentoo.org/921137