Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/capstone: drop 4.0.2-r2, various maintenance #36470

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

dev-libs/capstone: drop 4.0.2-r2, various maintenance #36470

wants to merge 4 commits into from
+21 −110

Conversation

hamarituc
Copy link
Contributor

@hamarituc
dev-libs/capstone: remove 'distutils_enable_tests setup.py'
155e996 
Closes: https://bugs.gentoo.org/927518
Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
@hamarituc
dev-libs/capstone: fix patch for upstream changes
62fd9c3 
Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
@hamarituc
dev-libs/capstone: add missing RESTRICT
630989b 
Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
@hamarituc
dev-libs/capstone: drop 4.0.2-r2
2395545 
Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @hamarituc
Areas affected: ebuilds
Packages affected: dev-libs/capstone

dev-libs/capstone: @hamarituc, @gentoo/proxy-maint

Linked bugs

Bugs linked: 927518

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 28, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-04-28 15:34 UTC
Newest commit scanned: 2395545
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/71eaf5f333/output.html

mgorny
mgorny requested changes Apr 28, 2024
View reviewed changes
dev-libs/capstone/capstone-5.0.1.ebuild
@@ -90,3 +88,7 @@ src_install() {
find "${ED}" -name '*.a' -delete || die
fi
}

python_test() {
emake check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the Makefile, this isn't going to work, as this target doesn't fail if tests fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@hamarituc @gentoo-bot @gentoo-repo-qa-bot @mgorny